Fix #145: add a shading cheat

[josephcsible]

No description provided.

[zenorogue]

Looks good, although from reading the diff, it seems that it does not turn off when you exit the cheat mode, so it could be used to cheat outside the cheat mode. (Could be fixed by turning shadingcheat off if not cheater, similar to how it is done for camelotcheat, or by changing the checks into shadingcheat && cheater, possibly made into a function.)

Also one legal remark (it seems I have not asked you about this in 2021 for some reason): since the paid versions of HyperRogue (and potentially other RogueViz games) have components which are not open source (such as the Steam interface), I need your permission to include your changes there (otherwise it violates the GPL). What are your thoughts on this? (Posting a permission here is OK.)

[josephcsible]

Looks good, although from reading the diff, it seems that it does not turn off when you exit the cheat mode, so it could be used to cheat outside the cheat mode. (Could be fixed by turning shadingcheat off if not cheater, similar to how it is done for camelotcheat, or by changing the checks into shadingcheat && cheater, possibly made into a function.)

Okay, now I turn shadingcheat back off the same place that timerghost and gen_wandering get turned back on.

Also one legal remark (it seems I have not asked you about this in 2021 for some reason): since the paid versions of HyperRogue (and potentially other RogueViz games) have components which are not open source (such as the Steam interface), I need your permission to include your changes there (otherwise it violates the GPL). What are your thoughts on this? (Posting a permission here is OK.)

That's fine with me. Do you have a full list of such libraries? If so, I'll post the FSF's recommended wording from https://www.gnu.org/licenses/gpl-faq.en.html#GPLIncompatibleLibs with them filled in.

[zenorogue]

A good and interesting idea about including that wording. However, I might want to put HyperRogue on any Steam-like service that may eventually appear in the future, so there is no full list.