Make painttype an enum #479
Conversation
| int paintwhat = 0; | ||
| int paintwhat_alt_wall = 0; | ||
| int painttype = 0; | ||
| enum class ePainttype { monsters, items, lands, walls, copy, boundary, paint, select, teleport }; |
There was a problem hiding this comment.
FWIW, I always prefer to see enums with explicit sizes (underlying types). Makes it clearer how big they are, which is never harmful to know and can sometimes be helpful (struct layout). So I'd make this
enum class ePainttype : int {
or even
enum class ePainttype : unsigned char {
(not that it matters in this particular case AFAICT at first glance).
There was a problem hiding this comment.
I'm fine with that, but I don't think it's Zeno's style, since there are dozens of enums in HyperRogue already, of which only three (eModel, ptype, and ePattern) specify an underlying type.
|
Yes, I am treating non-typed enums like "int" (maybe some other type would be enough but there is not much point to care in this particular situation). I think there are some other cases where something should be an enum but is an int for historical/laziness reasons. |
3 participants
No description provided.