Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add getters to private properties, re: #148 #150

Open
wants to merge 6 commits into
base: 1.x
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update src/Browser/PantherBrowser.php
Co-authored-by: Nicolas PHILIPPE <nikophil@gmail.com>
tacman and nikophil authored Jul 22, 2024
commit a93dc823b56de3580796fb17917f52adae8ded78
3 changes: 3 additions & 0 deletions src/Browser/PantherBrowser.php
Original file line number Diff line number Diff line change
@@ -238,12 +238,15 @@
return $this->consoleLogDir;
}

/**
* @return list<string>
*/
public function getSavedScreenshots(): array
{
return $this->savedScreenshots;
}

public function getSavedConsoleLogs(): array

Check failure on line 249 in src/Browser/PantherBrowser.php

GitHub Actions / sca / Static Code Analysis

Method Zenstruck\Browser\PantherBrowser::getSavedConsoleLogs() return type has no value type specified in iterable type array.
{
return $this->savedConsoleLogs;
}