resetting return on Unexpected EOF (its a VPN issue)

zephinzer · Jun 29, 2021 · 44f87bf · 44f87bf
1 parent eb23d5c
commit 44f87bf
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/pkg/xtermjs/handler_websocket.go b/pkg/xtermjs/handler_websocket.go
@@ -102,7 +102,9 @@ func GetHandler(opts HandlerOpts) func(http.ResponseWriter, *http.Request) {
 		go func() {
 			errorCounter := 0
 			for {
-				// consider the connection closed/errored out
+				// consider the connection closed/errored out so that the socket handler
+				// can be terminated - this frees up memory so the service doesn't get
+				// overloaded
 				if errorCounter > connectionErrorLimit {
 					waiter.Done()
 					break
@@ -135,7 +137,6 @@ func GetHandler(opts HandlerOpts) func(http.ResponseWriter, *http.Request) {
 				if err != nil {
 					if !connectionClosed {
 						clog.Warnf("failed to get next reader: %s", err)
-						continue
 					}
 					return
 				}