Revert "libgcc: gthr: support for --enable-threads=c11" until compatibility issue is resolved
#30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 47b9276. Signed-off-by: Stephanos Ioannidis <[email protected]>
This reverts commit 52dc7f4. Signed-off-by: Stephanos Ioannidis <[email protected]>
This reverts commit 685f451. Signed-off-by: Stephanos Ioannidis <[email protected]>
|
@cfriedt This is intended to revert the These patches can be re-introduced when they are reworked to not break compatibility with prior Zephyr releases as described above. Alternatively, they can be introduced as-is for Zephyr SDK 0.17.0, which is intended to be a release with breaking changes. |
|
Merging since #31 still has remaining issues (see zephyrproject-rtos/sdk-ng#755), and going through more iterations to fix this issue would further delay the new SDK release that many have been waiting for. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series reverts the support for C11 threads-based gthread implementation introduced in #27 because it breaks non-multithreaded C++ applications and requires the introduction of special C11 threads stub functions on the Zephyr side, which creates an incompatibility between the latest Zephyr SDK release and earlier Zephyr releases.
The patch should be reworked to provide the weak stub implementations of the C11 threads functions within libgcc, as described in zephyrproject-rtos/sdk-ng#751 (comment), to ensure that it does not break compatibility with the prior Zephyr releases.