Skip to content

NXP Iw416 and nw61x wifi and bt soc support#512

Merged
dleach02 merged 2 commits intozephyrproject-rtos:masterfrom
nxp-upstream:iw416_nw6ax_wifi_enablement
Apr 24, 2025
Merged

NXP Iw416 and nw61x wifi and bt soc support#512
dleach02 merged 2 commits intozephyrproject-rtos:masterfrom
nxp-upstream:iw416_nw6ax_wifi_enablement

Conversation

@abhinavnxp
Copy link
Copy Markdown
Contributor

@abhinavnxp abhinavnxp commented Feb 13, 2025

Adding support for firmware blobs and hal changes for IW416 and IW61x socs of NXP.

@abhinavnxp abhinavnxp changed the title NXP Iw416 and nw61x wifi and bt enablement for firmware blobs NXP Iw416 and nw61x wifi and bt firmware blobs update Feb 13, 2025
@cdesjardins
Copy link
Copy Markdown

cdesjardins commented Feb 13, 2025

I just tried this patch, it is exactly what I need, however I am not finding the binary files.

component_wifi_bt_module_tx_pwr_limits component is included.
CMake Error at C:/Users/cjdes/sw/legato/modules/hal/nxp/zephyr/src/rt/CMakeLists.txt:56 (message):
  Couldn't find wifi/bt firmware !
....modules/hal/nxp/zephyr/blobs/nw61x/sduart_nw61x.bin.se

Am I missing something?

@abhinavnxp
Copy link
Copy Markdown
Contributor Author

abhinavnxp commented Feb 13, 2025

Working on blobs repo PR for firmware!

@MaochenWang1 MaochenWang1 self-requested a review February 17, 2025 06:05
@MaochenWang1
Copy link
Copy Markdown
Collaborator

MaochenWang1 commented Feb 17, 2025

Update wifi_nxp to support IW416 and IW61x in this single PR.

@MaochenWang1
Copy link
Copy Markdown
Collaborator

MaochenWang1 commented Feb 17, 2025

Please review @dleach02 @decsny @mmahadevan108

@abhinavnxp abhinavnxp changed the title NXP Iw416 and nw61x wifi and bt firmware blobs update NXP Iw416 and nw61x wifi and bt soc support Feb 17, 2025
@cdesjardins
Copy link
Copy Markdown

cdesjardins commented Feb 17, 2025

I tested this with imxrt1060-evkc and IW612_MURATA_2EL_M2, and it worked well along with this patch: zephyrproject-rtos/zephyr#85749

Still missing the firmware blobs, but I managed to hack around that.

@MaochenWang1 MaochenWang1 mentioned this pull request Feb 24, 2025
Closed
This was referenced Mar 6, 2025
Merged
Closed
@abhinavnxp abhinavnxp force-pushed the iw416_nw6ax_wifi_enablement branch 2 times, most recently from 71b09bd to 8df5b00 Compare March 17, 2025 07:56
@MaochenWang1
Copy link
Copy Markdown
Collaborator

MaochenWang1 commented Mar 17, 2025 •
edited
Loading

Update wifi_nxp to support IW416 and IW61x in this single PR, to let the build passed

@zephyrbot zephyrbot mentioned this pull request Mar 18, 2025
Merged
facchinm added a commit to facchinm/zephyr that referenced this pull request Mar 19, 2025
@facchinm
temp: plin: enable wifi and disable eth
5d3cdfa 
Requires zephyrproject-rtos/hal_nxp#512
@dleach02
Copy link
Copy Markdown
Member

dleach02 commented Mar 27, 2025

@abhinavnxp please address the merge conflict

decsny
decsny reviewed Mar 28, 2025
View reviewed changes
Comment thread zephyr/src/rt/CMakeLists.txt
Copy link
Copy Markdown
Member

@decsny decsny Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering why do we put this glue code CMake and C files in zephyr/src folder in HAL instead of in zephyr tree? is there a reason? because now if we merge this here then every time someone wants to change this file then we need to synchronize HAL PR with Zephyr manifest update, which adds process overhead and delays, are you sure you want to be putting this here? I know it was already done like this for RW but I did not see it before, and honestly don't know if there is a reason, if there is then LMK

Copy link
Copy Markdown
Member

@dleach02 dleach02 Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully the file doesn't really change much.

@carlescufi I looked at the blob documentation but it doesn't really explicitly call this out. I seem to remember that this was a discussion point in the process meeting about this topic. Do you have any recommendation or comment?

Comment thread mcux/middleware/wifi_nxp/LICENSE
Comment thread mcux/middleware/wifi_nxp/CMakeLists.txt
mmahadevan108
mmahadevan108 reviewed Mar 28, 2025
View reviewed changes
Comment thread zephyr/module.yml
@mmahadevan108 mmahadevan108 mentioned this pull request Mar 28, 2025
Closed
2 tasks
mmahadevan108
mmahadevan108 reviewed Mar 28, 2025
View reviewed changes
Comment thread zephyr/src/rt/8801/8801_cpu1.c Outdated
mmahadevan108
mmahadevan108 reviewed Mar 28, 2025
View reviewed changes
Comment thread zephyr/src/rw61x/CMakeLists.txt
mmahadevan108
mmahadevan108 reviewed Mar 28, 2025
View reviewed changes
Comment thread zephyr/src/rt/CMakeLists.txt Outdated
mmahadevan108
mmahadevan108 reviewed Apr 1, 2025
View reviewed changes
Comment thread zephyr/src/rt/CMakeLists.txt
lylezhu2012
lylezhu2012 reviewed Apr 2, 2025
View reviewed changes
Comment thread zephyr/src/rt/CMakeLists.txt Outdated
Comment thread zephyr/src/rt/CMakeLists.txt
Comment thread zephyr/src/rt/CMakeLists.txt Outdated
Comment thread zephyr/src/rt/CMakeLists.txt
@abhinavnxp abhinavnxp force-pushed the iw416_nw6ax_wifi_enablement branch from 48cb758 to 1e1ca13 Compare April 3, 2025 10:44
@abhinavnxp abhinavnxp requested a review from MaochenWang1 April 3, 2025 10:49
@nirav-agrawal nirav-agrawal force-pushed the iw416_nw6ax_wifi_enablement branch from 1e1ca13 to 762969b Compare April 7, 2025 09:33
@abhinavnxp abhinavnxp force-pushed the iw416_nw6ax_wifi_enablement branch from 762969b to 2da41a2 Compare April 11, 2025 13:06
@hakehuang
Copy link
Copy Markdown
Contributor

hakehuang commented Apr 14, 2025

I tested this with imxrt1060-evkc and IW612_MURATA_2EL_M2, and it worked well along with this patch: zephyrproject-rtos/zephyr#85749

Still missing the firmware blobs, but I managed to hack around that.

pre my understandinging this will block github CI as we do not run west blobs fetch. @cdesjardins am I right?

mmahadevan108
mmahadevan108 reviewed Apr 14, 2025
View reviewed changes
Comment thread zephyr/src/rt/nw61x/nw61x_cpu2.c
@abhinavnxp abhinavnxp force-pushed the iw416_nw6ax_wifi_enablement branch from 2da41a2 to 837c9a9 Compare April 16, 2025 03:50
ZhaoxiangJin
ZhaoxiangJin approved these changes Apr 16, 2025
View reviewed changes
Comment thread mcux/middleware/wifi_nxp/CMakeLists.txt
@MaochenWang1
mcux: wifi_nxp: update wifi version to v1.3.r51.z_up.p3
046295d 
Update wifi version to v1.3.r51.z_up.p3 to add features and bug fixes.
Support STA only mode (no SAP).
Add support for IW416 and IW61x.
Add RSNO support.

Signed-off-by: Maochen Wang <maochen.wang@nxp.com>
@MaochenWang1 MaochenWang1 force-pushed the iw416_nw6ax_wifi_enablement branch from 837c9a9 to c1f6dd0 Compare April 16, 2025 08:34
@MaochenWang1
Copy link
Copy Markdown
Collaborator

MaochenWang1 commented Apr 16, 2025

Fix the conflict

@abhinavnxp @nirav-agrawal
Zephyr: Src: Added files for IW416 and IW612 SoCs to work
a660378 
Adding support for IW416 and IW612 socs.

Signed-off-by: Abhinav Kulkarni <abhinav.kulkarni@nxp.com>
@nirav-agrawal nirav-agrawal force-pushed the iw416_nw6ax_wifi_enablement branch from c1f6dd0 to a660378 Compare April 23, 2025 06:29
@dleach02 dleach02 merged commit 601e1e5 into zephyrproject-rtos:master Apr 24, 2025
@abhinavnxp abhinavnxp deleted the iw416_nw6ax_wifi_enablement branch April 25, 2025 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZhaoxiangJin ZhaoxiangJin ZhaoxiangJin approved these changes

@MaochenWang1 MaochenWang1 MaochenWang1 approved these changes

@decsny decsny Awaiting requested review from decsny

@mmahadevan108 mmahadevan108 Awaiting requested review from mmahadevan108

@lylezhu2012 lylezhu2012 Awaiting requested review from lylezhu2012

+2 more reviewers

@nirav-agrawal nirav-agrawal nirav-agrawal left review comments

@dleach02 dleach02 dleach02 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@abhinavnxp @cdesjardins @MaochenWang1 @dleach02 @hakehuang @mmahadevan108 @lylezhu2012 @decsny @ZhaoxiangJin @nirav-agrawal