-
Notifications
You must be signed in to change notification settings - Fork 16
Create timer reqs #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Import Timer requirements from zephyrproject-rtos#75 pull request. Fixes zephyrproject-rtos#65 Signed-off-by: Stephane Parenti <[email protected]>
Merge requirements when possible Rename status to number of times expired Fixes zephyrproject-rtos#65 Signed-off-by: Stephane Parenti <[email protected]>
Rework expiry context requirement Fixes zephyrproject-rtos#65 Signed-off-by: Stephane Parenti [email protected]
|
I have reviewed, but wanted to check which portion of the code these requirements are intended to map to. I used timer.c in the kernel section - https://github.com/zephyrproject-rtos/zephyr/blob/5c7c3980eb0600a058d4355e3d101078f88d26dc/kernel/timer.c#L189 I understand all of the requirements as written and agree with them, but wanted to check that the list is complete. timer.c also references multithreading and has code comments for safety which I don't see in this PR. |
The requirements were written of https://docs.zephyrproject.org/apidoc/latest/group__timer__apis.html (which will be used/modified in future as unit/component design reqs) I haven't reviewed all the code re safety/user space/multithreading.
I may be missing part of your remark though as I do not have the tech. knowledge |
|
Thank you. I will then mark this PR reviewed and approve. |
|
I am not an approving reviewer for this task so it does not look like I can move this past the current status. |
|
@woodmatthews I just added you as reviewer. |
woodmatthews
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed this PR and compared with the API documentation.
|
Approvals are in for 88, 89, and 90.
Matt
…________________________________
From: Stéphane PARENTI ***@***.***>
Sent: Tuesday, July 29, 2025 9:55 AM
To: zephyrproject-rtos/reqmgmt ***@***.***>
Cc: Wood, Matthew (US-DF) ***@***.***>; Mention ***@***.***>
Subject: Re: [zephyrproject-rtos/reqmgmt] Create timer reqs (PR #88)
[https://avatars.githubusercontent.com/u/5610045?s=20&v=4]parphane left a comment (zephyrproject-rtos/reqmgmt#88)<#88 (comment)>
@woodmatthews<https://github.com/woodmatthews> I just added you as reviewer
—
Reply to this email directly, view it on GitHub<#88 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BMEL4UKLIBKHQWBC2LVHZQD3K54NDAVCNFSM6AAAAAB7WPDH2SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCMZSGY2DOOBUGE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Imported files from #75
Fixes changes per #75 comments
Updated terminology, simplified requirements and updated requirements ID
Closes #65