net: ocpp: several OCPP fixes #101196
Open
net: ocpp: several OCPP fixes #101196
+114
−146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markushx
force-pushed
the
ocpp-fixes
branch
2 times, most recently
from
a97d048 to
d6ab05f
Compare
Logging had a lot of trailing \n. Signed-off-by: Markus Becker <[email protected]>
BootNotification did not transport Serial Number and other information, because the NULL check is wrong. Signed-off-by: Markus Becker <[email protected]>
Writable string entries in ocpp_cfg_info are free'd if non NULL in ocpp_set_cfg_val(). Thus they should not be statically allocated. Initialise with NULL instead. CFG_SUPPORTED_FEATURE_PROFILE is not writable and should be fine. Signed-off-by: Markus Becker <[email protected]>
OCPP pongs do not carry payload and cannot be NET_DBG'd without crash. Signed-off-by: Markus Becker <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OCPP implementation had a few issues: