Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: eth: fix stm32_hal PHY address resolution #77761

Merged
merged 1 commit into from
Sep 3, 2024
Merged

drivers: eth: fix stm32_hal PHY address resolution #77761

merged 1 commit into from
Sep 3, 2024

Conversation

scaprile
Copy link
Contributor

Fixes: #77705

Fix wrong macro.
Tested with all the boards mentioned in that issue, build now works.

@zephyrbot zephyrbot added size: XS A PR changing only a single line of code platform: STM32 ST Micro STM32 area: Ethernet labels Aug 29, 2024
Copy link

Hello @scaprile, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@AlexFabre
Copy link
Contributor

This wrong macro call is my mistake, sorry for that.

@pdgendt
Copy link
Collaborator

pdgendt commented Aug 30, 2024

Please rebase as the CI issue has been fixed in main.

Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scaprile Please remove the merge commit.

@scaprile scaprile closed this Aug 30, 2024
@scaprile
Copy link
Contributor Author

@scaprile Please remove the merge commit.

@erwango Github closed this commit when I force pushed on my fork... (?) can you reopen ? (I can't)

Fixes: #77705

Fix wrong macro.
Tested with all the boards mentioned in that issue, build now works.

Signed-off-by: Sergio R. Caprile <[email protected]>
@pdgendt
Copy link
Collaborator

pdgendt commented Aug 30, 2024

There are no commits on your main branch anymore.

@scaprile scaprile reopened this Aug 30, 2024
@scaprile
Copy link
Contributor Author

Yeah, I must have screwed something and blamed Github... added on top
Thanks.

@scaprile scaprile requested a review from erwango August 30, 2024 14:25
@carlescufi carlescufi merged commit 360522a into zephyrproject-rtos:main Sep 3, 2024
34 checks passed
Copy link

github-actions bot commented Sep 3, 2024

Hi @scaprile!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Ethernet platform: STM32 ST Micro STM32 size: XS A PR changing only a single line of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stm32: eth: build issue after PHY address resolution fix (84889d4)
9 participants