Add MAX78000 SoC and its EVKIT and FTHR boards. #83976

yasinustunerg · 2025-01-14T19:32:28Z

This PR adds MAX78000 and its EVKIT and FTHR boards.

Add MAX78000 SoC
Add MAX78000EVKIT board.
Add MAX78000FTHR board.

Supported interfaces:

UART
GPIO
Clock control
Flash
Watchdog
TRNG
DMA
PWM
ADC
SPI
I2C
Counter
1-Wire

Signed-off-by: Yasin Ustuner [email protected]

github-actions · 2025-01-14T19:33:16Z

Hello @yasinustunerg, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

zephyrbot · 2025-01-14T21:31:50Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff
hal_adi	zephyrproject-rtos/hal_adi@`b1a1023`	zephyrproject-rtos/hal_adi@`a9ca7d1` (`main`)	zephyrproject-rtos/[email protected]

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

kartben · 2025-01-21T17:46:38Z

this can be safely re-assigned to ADI platform maintainers :) Still needs a second +1 though

ozersa · 2025-01-22T07:31:36Z

dts/arm/adi/max32/max78000.dtsi

+&timer0 {
+	pwm {
+		pinctrl-0 = <&tmr0a_ioa_p0_2>;
+		pinctrl-names = "default";
+	};
+};
+
+&timer1 {
+	pwm {
+		pinctrl-0 = <&tmr1a_ioa_p0_14>;
+		pinctrl-names = "default";
+	};
+};
+
+&timer2 {
+	pwm {
+		pinctrl-0 = <&tmr2_ioa_p0_26>;
+		pinctrl-names = "default";
+	};
+};
+
+&timer3 {
+	pwm {
+		pinctrl-0 = <&tmr3a_ioa_p1_6>;
+		pinctrl-names = "default";
+	};
+};


Timer default pin setting shall not be part of SoC part, might be part of the board file.
There are multiple pin option for timer output, like for timer0

I think it shall not be restricted in SoC layer.

Hi @ozersa,

Removed, thanks.

This commit adds MAX78000 SoC and dts files. Signed-off-by: Yasin Ustuner <[email protected]>

The SystemCoreClock variable must be placed in the '.shared' section for the MAX78000 and MAX78002 because the ARM core is responsible for changing the System Clock and updating the SystemCoreClock variable, and the RISC-V core knows what the System Clock frequency is through the shared variable. Signed-off-by: Yasin Ustuner <[email protected]>

This commit adds binding file for DMA slots. Signed-off-by: Yasin Ustuner <[email protected]>

ozersa · 2025-01-22T11:24:30Z

tests/drivers/w1/w1_api/boards/max78000fthr_max78000_m4.overlay

+	pinctrl-0 = <&owm_io_p0_6 &owm_pe_p0_7>;
+	pinctrl-names = "default";


Will be better if it be moved into board file as spi/i2c....
Also while moving this to the board you should change the owm pins to P0.18 & P0.19 due to P0.6 & P0.7 conflicts with SPI.

Hi @ozersa ,

Done

Thanks for moving them to the board files, it is better.
Regarding my pin check request, I just checked EvKit and FTHR schematic,
For MAX78000FTHR there is no P0.18 pin out, so it is need to be P0.6 & P0.7

Fixed, thanks.

ozersa · 2025-01-22T14:22:17Z

boards/adi/max78000evkit/board.cmake

+
+board_runner_args(openocd --cmd-pre-init "source [find interface/cmsis-dap.cfg]")
+board_runner_args(openocd --cmd-pre-init "source [find target/max78000.cfg]")
+board_runner_args(openocd --cmd-pre-init "allow_low_pwr_dbg")


Just a note requires final version ADI openocd been used for "allow_low_pwr_dbg" parameter.

This commit adds MAX78000EVKIT board. Signed-off-by: Yasin Ustuner <[email protected]>

Enable following tests for MAX78000EVKIT: - tests/drivers/adc/adc_api - tests/drivers/counter/counter_basic_api - tests/drivers/dma/chan_blen_transfer - tests/drivers/dma/loop_transfer - tests/drivers/gpio/gpio_basic_api - tests/drivers/pwm/pwm_api - tests/drivers/w1/w1_api Signed-off-by: Yasin Ustuner <[email protected]>

Enable following sample for MAX78000EVKIT: - samples/drivers/counter/alarm Signed-off-by: Yasin Ustuner <[email protected]>

This commit adds MAX78000FTHR board. Signed-off-by: Yasin Ustuner <[email protected]>

Enable the following tests for MAX78000FTHR: - tests/drivers/adc/adc_api - tests/drivers/counter/counter_basic_api - tests/drivers/dma/chan_blen_transfer - tests/drivers/dma/loop_transfer - tests/drivers/gpio/gpio_basic_api - tests/drivers/pwm/pwm_api - tests/drivers/spi/spi_loopback - tests/drivers/w1/w1_api Signed-off-by: Yasin Ustuner <[email protected]>

Enable following sample for MAX78000FTHR: - samples/drivers/counter/alarm Signed-off-by: Yasin Ustuner <[email protected]>

github-actions · 2025-01-22T19:48:08Z

Hi @yasinustunerg!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

yasinustunerg changed the title ~~soc: adi: Add the MAX78000 SoC~~ Add MAX78000 SoC and its EVKIT and FTHR boards. Jan 14, 2025

yasinustunerg force-pushed the Add-MAX78000-Board branch from 82f8c5a to c2a6fd0 Compare January 14, 2025 21:30

zephyrbot added manifest manifest-hal_adi DNM This PR should not be merged (Do Not Merge) labels Jan 14, 2025

yasinustunerg marked this pull request as ready for review January 14, 2025 21:45

zephyrbot added area: DMA Direct Memory Access area: PWM Pulse Width Modulation platform: ADI Analog Devices, Inc. area: ADC Analog-to-Digital Converter (ADC) area: W1 1-Wire area: GPIO area: SPI SPI bus area: Counter area: Samples Samples labels Jan 14, 2025

zephyrbot requested review from anangl, casparfriedrich, galak, henrikbrixandersen, kartben, MaureenHelm, microbuilder, mnkp, nashif, nordic-krch, ozersa, str4t0m and tbursztyka January 14, 2025 21:46

ozersa reviewed Jan 22, 2025

View reviewed changes

yasin-ADI added 3 commits January 22, 2025 11:03

soc: adi: Add the MAX78000 SoC

96aa7a8

This commit adds MAX78000 SoC and dts files. Signed-off-by: Yasin Ustuner <[email protected]>

include: zephyr: dt-bindings: Add MAX78000 DMA binding

46ccc97

This commit adds binding file for DMA slots. Signed-off-by: Yasin Ustuner <[email protected]>

yasinustunerg dismissed MaureenHelm’s stale review via 0a6b048 January 22, 2025 08:30

yasinustunerg force-pushed the Add-MAX78000-Board branch from 56e351b to 0a6b048 Compare January 22, 2025 08:30

yasinustunerg requested review from ozersa and MaureenHelm January 22, 2025 08:30

ozersa reviewed Jan 22, 2025

View reviewed changes

yasinustunerg force-pushed the Add-MAX78000-Board branch 2 times, most recently from 48eaa21 to 5714641 Compare January 22, 2025 14:07

yasinustunerg requested a review from ozersa January 22, 2025 14:14

ozersa reviewed Jan 22, 2025

View reviewed changes

ozersa previously approved these changes Jan 22, 2025

View reviewed changes

yasin-ADI added 6 commits January 22, 2025 17:31

boards: adi: Add MAX78000EVKIT board

b4b92cb

This commit adds MAX78000EVKIT board. Signed-off-by: Yasin Ustuner <[email protected]>

samples: Add MAX78000EVKIT sample overlay files

faf3056

Enable following sample for MAX78000EVKIT: - samples/drivers/counter/alarm Signed-off-by: Yasin Ustuner <[email protected]>

boards: adi: Add MAX78000FTHR board

24d4532

This commit adds MAX78000FTHR board. Signed-off-by: Yasin Ustuner <[email protected]>

samples: Add MAX78000FTHR sample overlay files

b45bf01

Enable following sample for MAX78000FTHR: - samples/drivers/counter/alarm Signed-off-by: Yasin Ustuner <[email protected]>

yasinustunerg dismissed ozersa’s stale review via b45bf01 January 22, 2025 14:34

yasinustunerg force-pushed the Add-MAX78000-Board branch from 5714641 to b45bf01 Compare January 22, 2025 14:34

yasinustunerg requested a review from ozersa January 22, 2025 14:34

ttmut approved these changes Jan 22, 2025

View reviewed changes

MaureenHelm approved these changes Jan 22, 2025

View reviewed changes

ozersa approved these changes Jan 22, 2025

View reviewed changes

kartben merged commit 0689d6d into zephyrproject-rtos:main Jan 22, 2025
28 checks passed

yasinustunerg deleted the Add-MAX78000-Board branch January 23, 2025 07:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add MAX78000 SoC and its EVKIT and FTHR boards. #83976

Add MAX78000 SoC and its EVKIT and FTHR boards. #83976

yasinustunerg commented Jan 14, 2025

github-actions bot commented Jan 14, 2025

zephyrbot commented Jan 14, 2025 •

edited

Loading

kartben commented Jan 21, 2025

ozersa Jan 22, 2025

yasinustunerg Jan 22, 2025

ozersa Jan 22, 2025

yasinustunerg Jan 22, 2025

ozersa Jan 22, 2025

yasinustunerg Jan 22, 2025

ozersa Jan 22, 2025 •

edited

Loading

yasinustunerg Jan 22, 2025

github-actions bot commented Jan 22, 2025

		pinctrl-0 = <&owm_io_p0_6 &owm_pe_p0_7>;
		pinctrl-names = "default";

Add MAX78000 SoC and its EVKIT and FTHR boards. #83976

Add MAX78000 SoC and its EVKIT and FTHR boards. #83976

Conversation

yasinustunerg commented Jan 14, 2025

github-actions bot commented Jan 14, 2025

zephyrbot commented Jan 14, 2025 • edited Loading

kartben commented Jan 21, 2025

ozersa Jan 22, 2025

Choose a reason for hiding this comment

yasinustunerg Jan 22, 2025

Choose a reason for hiding this comment

ozersa Jan 22, 2025

Choose a reason for hiding this comment

yasinustunerg Jan 22, 2025

Choose a reason for hiding this comment

ozersa Jan 22, 2025

Choose a reason for hiding this comment

yasinustunerg Jan 22, 2025

Choose a reason for hiding this comment

ozersa Jan 22, 2025 • edited Loading

Choose a reason for hiding this comment

yasinustunerg Jan 22, 2025

Choose a reason for hiding this comment

github-actions bot commented Jan 22, 2025

zephyrbot commented Jan 14, 2025 •

edited

Loading

ozersa Jan 22, 2025 •

edited

Loading