You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch updates the modules/lvgl/CMakeLists.txt to include the lv_arclabel.c source file in the Zephyr build.
Without this change, the arclabel widget from LVGL was not compiled into Zephyr projects, making it unavailable for use. Adding this file ensures that arclabel functionality is included and usable.
Change:
Added ${LVGL_DIR}/src/widgets/arclabel/lv_arclabel.c to zephyr_library_sources.
Hello @YehudaEi, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊
The reason will be displayed to describe this comment to others. Learn more.
Saw this also while prepping for the 9.4 release but have not gotten around to it. Thank you for your PR. But the commit message needs adjusting. Use module instead of driver.
Add the lv_arclabel.c source file to modules/lvgl/CMakeLists.txt
so that the Arclabel widget is compiled and available in Zephyr projects.
Previously, the arclabel widget was not included, making it unusable.
Signed-off-by: Yehuda Eisenberg <[email protected]>
area: LVGLLight and Versatile Graphics Library Supportsize: XSA PR changing only a single line of code
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zephyrbot
added
area: LVGL
YehudaEi
force-pushed
the
fix-lvgl-arclabel
branch
from
This patch updates the
modules/lvgl/CMakeLists.txtto include thelv_arclabel.csource file in the Zephyr build.Without this change, the arclabel widget from LVGL was not compiled into Zephyr projects, making it unavailable for use. Adding this file ensures that arclabel functionality is included and usable.
Change:
${LVGL_DIR}/src/widgets/arclabel/lv_arclabel.ctozephyr_library_sources.