Skip to content

drivers: mipi-dbi-spi: fix initialization of SPI CS #97366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2025
Merged

drivers: mipi-dbi-spi: fix initialization of SPI CS #97366

merged 1 commit into from
Oct 14, 2025

Conversation

@jeremydick
Copy link
Contributor

Set cs_is_gpio only if there is a GPIO CS, configure the CS as a native hardware CS if not

This fixes incorrectly trying to use a GPIO CS when there isn't one

@jeremydick jeremydick mentioned this pull request Oct 10, 2025
Closed
@JarmouniA JarmouniA requested review from JarmouniA and decsny October 10, 2025 16:11
@JarmouniA JarmouniA mentioned this pull request Oct 10, 2025
Merged
5 tasks
decsny
decsny reviewed Oct 10, 2025
View reviewed changes
@jeremydick
Copy link
Contributor Author

Failing CI test is due to #97379

@jeremydick
drivers: mipi-dbi-spi: fix initialization of SPI CS
fe468c5 
Set cs_is_gpio only if there is a GPIO CS, configure the CS as
a native hardware CS if not

This fixes incorrectly trying to use a GPIO CS when there isn't one

Signed-off-by: Jeremy Dick <[email protected]>
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@diegoherranz
Copy link
Contributor

+1 to this PR
I use a MIPI DBI screen with hardware-controlled chip select which suffered this regression.
I've tested this PR and it fixes the regression successfully.

Thanks.

@cfriedt cfriedt merged commit 011a357 into zephyrproject-rtos:main Oct 14, 2025
26 checks passed
JarmouniA
JarmouniA reviewed Oct 15, 2025
View reviewed changes
@JarmouniA JarmouniA mentioned this pull request Oct 15, 2025
Closed
1 task
@jeremydick jeremydick deleted the mipi-dbi-spi-hw-cs branch October 15, 2025 12:11
@JarmouniA JarmouniA mentioned this pull request Oct 17, 2025
Closed
@zbianbiaos
Copy link

011a357 drivers: mipi-dbi-spi: fix initialization of SPI CS
I have a question regarding devices like the st7789. Previously, the corresponding SPI device was obtained through the "spi-dev" property of mipi-dbi, but now it seems problematic that it is no longer retrieved from spi-dev. I tested with my own custom board, and after merging this commit, my LCD no longer displays anything. Will there be any follow-up commits to address this issue? Or could this be a problem with my program?

@jeremydick
Copy link
Contributor Author

@zbianbiaos #98086 should address your issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JarmouniA JarmouniA JarmouniA approved these changes

@VynDragon VynDragon Awaiting requested review from VynDragon

@danieldegrasse danieldegrasse Awaiting requested review from danieldegrasse

@decsny decsny Awaiting requested review from decsny

Assignees

No one assigned

Labels

area: Display

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jeremydick @diegoherranz @zbianbiaos @JarmouniA @decsny @cfriedt