Skip to content

Conversation

etienne-lms
Copy link
Contributor

Correct STM32 SoC DTSI files and samples/tests DTS overlay files where DMA lists are not split by phandle and seemed to form unique phandles. This is not an issue with existing DT parsing macros and tools but may generate build errors if tools are more strict on the DTS implementation format.

No functional changes.

Correct STM32F4xx SoCs DMA lists that were not split by phandle and
seemed to form unique phandles. This is not currently as issue with
existing DT parsing macros and tools but may generate build errors
if tools are more strict on the DTS implementation formats.

Signed-off-by: Etienne Carriere <[email protected]>
Correct STM32H5xx SoCs DMA lists that were not split by phandle and
seemed to form unique phandles. This is not currently as issue with
existing DT parsing macros and tools but may generate build errors
if tools are more strict on the DTS implementation formats.

Clean indentation by the ways for the modified DTSI file lines.

Signed-off-by: Etienne Carriere <[email protected]>
Correct STM32H7xx SoCs DMA lists that were not split by phandle and
seemed to form unique phandles. This is not currently as issue with
existing DT parsing macros and tools but may generate build errors
if tools are more strict on the DTS implementation formats.

Signed-off-by: Etienne Carriere <[email protected]>
Correct DTS file DMA lists that were not split by phandle and
seemed to form unique phandles. This is not currently as issue with
existing DT parsing macros and tools but may generate build errors
if tools are more strict on the DTS implementation formats.

Signed-off-by: Etienne Carriere <[email protected]>
…lists

Correct nucleo_wba55cg board DTS overlay file DMA lists that was not
split by phandle and seemed to form a unique phandle. This is not
currently an issue with existing DT parsing macros and tools but may
generate build errors if tools are more strict on the DTS implementation
format.

Signed-off-by: Etienne Carriere <[email protected]>
Correct stm32h573i_dk DTS overlay file DMA list that was not split
by phandle and seemed to form unique phandle. This is not currently
an issue with existing DT parsing macros and tools but may generate
build errors if tools are more strict on the DTS implementation format.

Signed-off-by: Etienne Carriere <[email protected]>
Correct b_u858i_iot02a DTS overlay file DMA lists that was not split
by phandle and seemed to form a unique phandle. This is not currently
an issue with existing DT parsing macros and tools but may generate
build errors if tools are more strict on the DTS implementation format.

Signed-off-by: Etienne Carriere <[email protected]>
Correct STM32 boards DTS overlay files DMA lists that were not split
by phandle and seemed to form unique phandles. This is not currently
an issue with existing DT parsing macros and tools but may generate
build errors if tools are more strict on the DTS implementation format.

Signed-off-by: Etienne Carriere <[email protected]>
Correct STM32 boards DTS overlay files DMA lists that were not split
by phandle and seemed to form a unique phandle. This is not currently
an issue with existing DT parsing macros and tools but may generate
build errors if tools are more strict on the DTS implementation format.

Signed-off-by: Etienne Carriere <[email protected]>
Correct b_u585i_iot02a board DTS overlay file DMA lists that was not
split by phandle and seemed to form a unique phandle. This is not
currently an issue with existing DT parsing macros and tools but may
generate build errors if tools are more strict on the DTS implementation
format.

Signed-off-by: Etienne Carriere <[email protected]>
Copy link

Comment on lines -9 to +10
dmas = <&dma2 5 3 0x28440 0x03
&dma2 2 3 0x28480 0x03>;
dmas = <&dma2 5 3 0x28440 0x03>,
<&dma2 2 3 0x28480 0x03>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side note: We should also consider moving these to STM32_DMA_ macros usage

@mathieuchopstm
Copy link
Contributor

This is not an issue with existing DT parsing macros and tools but may generate build errors if tools are more strict on the DTS implementation format.

Existing files actually contain perfectly valid constructs per the DT Specification as far as I understand it:

image image
  1. Per [3], &dma expands to a phandle (u32 per Specification) so dmas = <&dma 0 0xA5> turns into e.g. dmas = <777 0 0xA5>.
  2. Per [2], dmas = <777 0 0xA5>, <777 1 0x5A> are concatenated into <777 0 0xA5 777 1 0x5A>.
  3. Per [1], dmas = <777 0 0xA5 777 1 0x5A> is a valid array of cells.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Boards/SoCs area: Modem area: Networking area: Samples Samples area: SPI SPI bus area: Tests Issues related to a particular existing or missing test area: UART Universal Asynchronous Receiver-Transmitter platform: STM32 ST Micro STM32

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants