modules: hal_nxp: disable access to quickaccess section for Cortex A CPU's #97371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
EmilioCBen,
JiafeiPan,
MaochenWang1,
PetervdPerk-NXP,
ZhaoxiangJin,
axelnxp,
bperseghetti,
decsny,
dleach02 and
manuargue
mmahadevan108
force-pushed
the
Fix_HAL_NXP_Cmake
branch
from
dbe94c9 to
c3ac2c1
Compare
dleach02
previously approved these changes
Oct 10, 2025
JiafeiPan
reviewed
Oct 11, 2025
modules/hal_nxp/mcux/CMakeLists.txt
Outdated
| zephyr_linker_sources_ifdef(CONFIG_ARCH_HAS_RAMFUNC_SUPPORT | ||
| RAMFUNC_SECTION | ||
| ${ZEPHYR_CURRENT_MODULE_DIR}/mcux/quick_access_code.ld | ||
| ) |
There was a problem hiding this comment.
How about change to the following code:
if(CONFIG_CPU_CORTEX_A)
zephyr_compile_definitions(FSL_SDK_DRIVER_QUICK_ACCESS_DISABLE)
else() # CONFIG_CPU_CORTEX_A
zephyr_linker_sources(RWDATA
${ZEPHYR_CURRENT_MODULE_DIR}/mcux/quick_access_data.ld
)
zephyr_linker_sources_ifdef(CONFIG_ARCH_HAS_RAMFUNC_SUPPORT
RAMFUNC_SECTION
${ZEPHYR_CURRENT_MODULE_DIR}/mcux/quick_access_code.ld
)
endif() # CONFIG_CPU_CORTEX_A
There was a problem hiding this comment.
Why is this needed for Cortex-A?
There was a problem hiding this comment.
Cortex-A core all the code and data are in DDR memory, and there is no quickaccess section on Cortex-A core's link script.
Not needed on Cortex-A as all code and data is in DDR memory and there is no quickaccess section in the Cortex-A linker script. Signed-off-by: Mahesh Mahadevan <[email protected]>
mmahadevan108
force-pushed
the
Fix_HAL_NXP_Cmake
branch
from
c3ac2c1 to
4017696
Compare
|
mmahadevan108
changed the title
dleach02
approved these changes
Oct 15, 2025
JiafeiPan
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes quickaccess section inaccessible for Cortex A CPU's