-
Notifications
You must be signed in to change notification settings - Fork 8.3k
stm32wba : ble-802.15.4 concurrent mode integration #97773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
stm32wba : ble-802.15.4 concurrent mode integration #97773
Conversation
|
The following west manifest projects have changed revision in this Pull Request:
Additional metadata changed:
⛔ DNM label due to: 1 project with metadata changes and 8 blob changes Note: This message is automatically posted and updated by the Manifest GitHub Action. |
37cc906 to
17625f4
Compare
33d57f2 to
f49cb30
Compare
|
sample.yaml files has been removed |
c11a0be to
fb4c0b6
Compare
|
A new commit fb4c0b6 "samples: boards: st: ble ieee802.15.4 concurrent mode cleaning" is submitted including modification allowing to fix coding issues and keep only useful code part for STMicroelectronics concurrent mode test |
3fde8f3 to
fce5a3e
Compare
fce5a3e to
05e6e49
Compare
erwango
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest, it is not clear to me what the sample is supposed to demonstrate and how it should be used: Are 2 boards required ? What are the features supported ?
IMO, it's better to focus on a minimal sample for which the purpose is clear and where all the possible configurations have been validated.
Otherwise, we'll get users raising questions, using it with wrong purpose or raising issues on options that are not essential.
samples/boards/st/ble_802154/ble_hr_802154_echo_client/CMakeLists.txt
Outdated
Show resolved
Hide resolved
samples/boards/st/ble_802154/ble_hr_802154_echo_client/CMakeLists.txt
Outdated
Show resolved
Hide resolved
samples/boards/st/ble_802154/ble_hr_802154_echo_client/src/app_ble.c
Outdated
Show resolved
Hide resolved
samples/boards/st/ble_802154/ble_hr_802154_echo_client/src/echo-client.c
Outdated
Show resolved
Hide resolved
samples/boards/st/ble_802154/ble_hr_802154_echo_client/README.rst
Outdated
Show resolved
Hide resolved
| ************ | ||
|
|
||
| This sample has been tested on the STMicroelectonics NUCLEO-WBA65RI board | ||
| (nucleo_wba65ri). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If 2 boards are required, please specify it here.
samples/boards/st/ble_802154/ble_hr_802154_echo_client/README.rst
Outdated
Show resolved
Hide resolved
samples/boards/st/ble_802154/ble_hr_802154_echo_client/README.rst
Outdated
Show resolved
Hide resolved
05e6e49 to
3b20eeb
Compare
4988d73 to
cae1152
Compare
samples/boards/st/ble_802154/ble_hr_802154_echo_client/src/echo-client.c
Outdated
Show resolved
Hide resolved
samples/boards/st/ble_802154/ble_hr_802154_echo_client/src/udp.c
Outdated
Show resolved
Hide resolved
samples/boards/st/ble_802154/ble_hr_802154_echo_client/README.rst
Outdated
Show resolved
Hide resolved
cae1152 to
da8327d
Compare
erwango
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a build test and some more changes would be required:
Building the default configuration reports warnings:
warning: MAX_THREAD_BYTES (defined at arch/Kconfig:405) was assigned the value '3' but got the value
''. Check these unsatisfied dependencies: USERSPACE (=n). See
http://docs.zephyrproject.org/latest/kconfig.html#CONFIG_MAX_THREAD_BYTES and/or look up
MAX_THREAD_BYTES in the menuconfig/guiconfig interface. The Application Development Primer, Setting
Configuration Values, and Kconfig - Tips and Best Practices sections of the manual might be helpful
too.
warning: NET_IF_MAX_IPV4_COUNT (defined at subsys/net/ip/Kconfig.ipv4:14) was assigned the value '3'
but got the value ''. Check these unsatisfied dependencies: NET_IPV4 (=n). See
http://docs.zephyrproject.org/latest/kconfig.html#CONFIG_NET_IF_MAX_IPV4_COUNT and/or look up
NET_IF_MAX_IPV4_COUNT in the menuconfig/guiconfig interface. The Application Development Primer,
Setting Configuration Values, and Kconfig - Tips and Best Practices sections of the manual might be
helpful too.
This should be fixed.
Buidling UDP=n/TCP=y reports errors. If only UDP is supported conditional code around UDP should be fixed (target_sources_ifdef(CONFIG_NET_UDP app PRIVATE src/udp.c) but maybe other a well)
Sample should be moved to samples/boards/st/bluetooth.
Finally, html rendered sample documentation could be read here: https://builds.zephyrproject.io/zephyr/pr/97773/docs/samples/boards/st/ble_802154/ble_hr_802154_echo_client/README.html#stm32_ble_hr_802154_echo_client
Looks ok to me, but please check if enhancements could be made (clear enough for reader).
samples/boards/st/ble_802154/ble_hr_802154_echo_client/src/common.h
Outdated
Show resolved
Hide resolved
da8327d to
4ce9db5
Compare
|
In the prj.conf of the sample, many IPV4 configuration are setting while NET_IPV4 is setting to 'n'. |
4ce9db5 to
bfd0ccd
Compare
|
Sample has been moved to samples/boards/st/bluetooth. |
Add parameter to the link_layer_register_isr() to force or not the link layer isr registration in case of multiple function calls Update Bluetooth hci_stm32wba.c driver and IEEE 802.15.4 ieee802154_stm32wba.c driver accordingly. Signed-off-by: Vincent Tardy <[email protected]>
Integration of the BLE-802.15.4 concurrent mode on stm32wba. Signed-off-by: Vincent Tardy <[email protected]>
Add sample Bluetooth Heart Rate - 802154 Echo Client Signed-off-by: Vincent Tardy <[email protected]>
bfd0ccd to
1dfac3e
Compare
|



Integration of the BLE-802.15.4 concurrent mode on stm32wba based on CubeWBA release 1.7.0
Add new sample application ble-802.15.4 echo_client concurrent mode