Skip to content

Conversation

@vtardy-st
Copy link
Contributor

Integration of the BLE-802.15.4 concurrent mode on stm32wba based on CubeWBA release 1.7.0
Add new sample application ble-802.15.4 echo_client concurrent mode

@github-actions
Copy link

github-actions bot commented Oct 17, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_stm32 zephyrproject-rtos/hal_stm32@286dd28 zephyrproject-rtos/hal_stm32@50fcec6 (main) zephyrproject-rtos/[email protected]

Additional metadata changed:

Name URL Submodules West cmds module.yml Blobs
hal_stm32 6x ✏, 2x 🆕

DNM label due to: 1 project with metadata changes and 8 blob changes

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@github-actions github-actions bot added manifest manifest-hal_stm32 DNM (manifest) This PR should not be merged (controlled by action-manifest) Binary Blobs Added labels Oct 17, 2025
@hermabe hermabe removed their request for review October 17, 2025 08:23
@vtardy-st vtardy-st marked this pull request as draft October 17, 2025 09:33
@vtardy-st vtardy-st force-pushed the stm32wba_1_7_0_ble_802154_concurrent branch from 37cc906 to 17625f4 Compare October 17, 2025 10:02
@vtardy-st vtardy-st force-pushed the stm32wba_1_7_0_ble_802154_concurrent branch 2 times, most recently from 33d57f2 to f49cb30 Compare November 14, 2025 15:36
@vtardy-st
Copy link
Contributor Author

sample.yaml files has been removed

@vtardy-st vtardy-st force-pushed the stm32wba_1_7_0_ble_802154_concurrent branch 3 times, most recently from c11a0be to fb4c0b6 Compare November 19, 2025 13:24
@vtardy-st
Copy link
Contributor Author

A new commit fb4c0b6 "samples: boards: st: ble ieee802.15.4 concurrent mode cleaning" is submitted including modification allowing to fix coding issues and keep only useful code part for STMicroelectronics concurrent mode test

@vtardy-st vtardy-st force-pushed the stm32wba_1_7_0_ble_802154_concurrent branch 2 times, most recently from 3fde8f3 to fce5a3e Compare November 26, 2025 11:43
@vtardy-st vtardy-st force-pushed the stm32wba_1_7_0_ble_802154_concurrent branch from fce5a3e to 05e6e49 Compare November 28, 2025 16:58
Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, it is not clear to me what the sample is supposed to demonstrate and how it should be used: Are 2 boards required ? What are the features supported ?

IMO, it's better to focus on a minimal sample for which the purpose is clear and where all the possible configurations have been validated.
Otherwise, we'll get users raising questions, using it with wrong purpose or raising issues on options that are not essential.

************

This sample has been tested on the STMicroelectonics NUCLEO-WBA65RI board
(nucleo_wba65ri).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If 2 boards are required, please specify it here.

@vtardy-st vtardy-st force-pushed the stm32wba_1_7_0_ble_802154_concurrent branch from 05e6e49 to 3b20eeb Compare December 2, 2025 13:08
@zephyrbot zephyrbot requested a review from erwango December 2, 2025 13:10
@vtardy-st vtardy-st force-pushed the stm32wba_1_7_0_ble_802154_concurrent branch 2 times, most recently from 4988d73 to cae1152 Compare December 2, 2025 13:52
@vtardy-st vtardy-st force-pushed the stm32wba_1_7_0_ble_802154_concurrent branch from cae1152 to da8327d Compare December 2, 2025 16:24
@zephyrbot zephyrbot requested a review from erwango December 2, 2025 16:26
Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a build test and some more changes would be required:

Building the default configuration reports warnings:

warning: MAX_THREAD_BYTES (defined at arch/Kconfig:405) was assigned the value '3' but got the value
''. Check these unsatisfied dependencies: USERSPACE (=n). See
http://docs.zephyrproject.org/latest/kconfig.html#CONFIG_MAX_THREAD_BYTES and/or look up
MAX_THREAD_BYTES in the menuconfig/guiconfig interface. The Application Development Primer, Setting
Configuration Values, and Kconfig - Tips and Best Practices sections of the manual might be helpful
too.


warning: NET_IF_MAX_IPV4_COUNT (defined at subsys/net/ip/Kconfig.ipv4:14) was assigned the value '3'
but got the value ''. Check these unsatisfied dependencies: NET_IPV4 (=n). See
http://docs.zephyrproject.org/latest/kconfig.html#CONFIG_NET_IF_MAX_IPV4_COUNT and/or look up
NET_IF_MAX_IPV4_COUNT in the menuconfig/guiconfig interface. The Application Development Primer,
Setting Configuration Values, and Kconfig - Tips and Best Practices sections of the manual might be
helpful too.

This should be fixed.

Buidling UDP=n/TCP=y reports errors. If only UDP is supported conditional code around UDP should be fixed (target_sources_ifdef(CONFIG_NET_UDP app PRIVATE src/udp.c) but maybe other a well)

Sample should be moved to samples/boards/st/bluetooth.

Finally, html rendered sample documentation could be read here: https://builds.zephyrproject.io/zephyr/pr/97773/docs/samples/boards/st/ble_802154/ble_hr_802154_echo_client/README.html#stm32_ble_hr_802154_echo_client
Looks ok to me, but please check if enhancements could be made (clear enough for reader).

@vtardy-st vtardy-st force-pushed the stm32wba_1_7_0_ble_802154_concurrent branch from da8327d to 4ce9db5 Compare December 3, 2025 10:00
@zephyrbot zephyrbot requested a review from erwango December 3, 2025 10:02
@vtardy-st
Copy link
Contributor Author

In the prj.conf of the sample, many IPV4 configuration are setting while NET_IPV4 is setting to 'n'.
This implementation is herited from echo-client sample (samples/net/sockets/echo_client) in order to enable/disable IPV4/IPV6 through the prj.conf.

@vtardy-st vtardy-st force-pushed the stm32wba_1_7_0_ble_802154_concurrent branch from 4ce9db5 to bfd0ccd Compare December 4, 2025 14:20
@vtardy-st
Copy link
Contributor Author

Sample has been moved to samples/boards/st/bluetooth.

Add parameter to the link_layer_register_isr() to force
or not the link layer isr registration in case of multiple
function calls

Update Bluetooth hci_stm32wba.c driver and
IEEE 802.15.4 ieee802154_stm32wba.c driver accordingly.

Signed-off-by: Vincent Tardy <[email protected]>
Integration of the BLE-802.15.4 concurrent mode on stm32wba.

Signed-off-by: Vincent Tardy <[email protected]>
Add sample Bluetooth Heart Rate - 802154 Echo Client

Signed-off-by: Vincent Tardy <[email protected]>
@vtardy-st vtardy-st force-pushed the stm32wba_1_7_0_ble_802154_concurrent branch from bfd0ccd to 1dfac3e Compare December 4, 2025 15:27
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 4, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants