Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTORS.md #20995

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Conversation

BasmaElhoseny01
Copy link
Contributor

I have added my name :D

@zero-to-mastery-bot
Copy link
Contributor

🥳 Congratulations 🎉

Congrats on making your first Pull Request in the Zero To Mastery Organization!
You have been sent an invitation to join the ZTM github organization, please check your emails for further details!

ZTM Profile Badge

If you'd like the ZTM Badge to show up on your profile, you will need to follow this guide!

@zero-to-mastery-bot
Copy link
Contributor

⚠️ MERGE CONFLICT DETECTED!

@BasmaElhoseny01 A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.

Before we can merge the code, you will need to resolve the conflict, check out these videos by Aldo: How To Get Started With Open Source and How To Resolve Git Merge Conflicts. If you get stuck ask over on Discord.

1 similar comment
@zero-to-mastery-bot
Copy link
Contributor

⚠️ MERGE CONFLICT DETECTED!

@BasmaElhoseny01 A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.

Before we can merge the code, you will need to resolve the conflict, check out these videos by Aldo: How To Get Started With Open Source and How To Resolve Git Merge Conflicts. If you get stuck ask over on Discord.

@zero-to-mastery-bot
Copy link
Contributor

🙏 Thanks for your pull request @BasmaElhoseny01, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
20995 4 1
📑 Files Changed: Repo Stars: 🔱 Total Forks:
1 2270 16003

1 similar comment
@zero-to-mastery-bot
Copy link
Contributor

🙏 Thanks for your pull request @BasmaElhoseny01, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
20995 4 1
📑 Files Changed: Repo Stars: 🔱 Total Forks:
1 2270 16003

@LaurelineP LaurelineP merged commit 70f8b43 into zero-to-mastery:master Oct 2, 2023
1 check passed
@LaurelineP
Copy link
Contributor

LaurelineP commented Oct 2, 2023

@BasmaElhoseny01 Thanks for your contribution.
Note the following for any other contributions in your journey: always create another branch
and avoid adding commits directly into any project's main branch ( here master ) :)
Have a nice developer journey 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants