Fix bogus server session released check in IceGrid node. #4625
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepone
commented
Nov 3, 2025
| // Remember if the server was just released by a session, this will be used later to not update the configuration | ||
| // on the disk (as an optimization and to allow users to review the configuration file after allocating a server -- | ||
| // that's useful if the server configuration is bogus and the session server can't start). | ||
| bool serverSessionReleased = _desc && _desc->activation == "session" && _desc->revision == descriptor->revision && |
There was a problem hiding this comment.
This check only makes sense if we do it before updating _desc.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where the serverSessionReleased flag was being calculated incorrectly due to premature assignment of _desc. The assignment of _desc = descriptor is moved to after the serverSessionReleased calculation, ensuring the old descriptor state is properly compared against the new one.
- Reordered variable assignments to preserve old state during session release detection
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
externl
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4624