Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return signed URL directly in TikTokSignatureProvider instead of calling sign URL endpoint #215

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hoangvu12
Copy link

@hoangvu12 hoangvu12 commented Jul 14, 2024

The webcast/sign_url endpoint is deprecated, so this PR rewrites the function to return the signed URL directly instead of calling the endpoint. This should theoretically improve the speed since the library will only need to make one request instead of two.

This PR also removes config and signEvents as they are not used elsewhere.

Breaking changes: this might cause issues for people who are using a custom host and the webcast/sign_url endpoint to sign URL. Additionally, this change eliminates the need for signProviderOptions.params and signProviderOptions.headers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant