Skip to content

chore: simplify http query array parsing#4637

Merged
kevwan merged 2 commits intozeromicro:masterfrom
kevwan:chore/refactor
Feb 8, 2025
Merged

chore: simplify http query array parsing#4637
kevwan merged 2 commits intozeromicro:masterfrom
kevwan:chore/refactor

Conversation

@kevwan
Copy link
Copy Markdown
Contributor

@kevwan kevwan commented Feb 8, 2025

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.57%. Comparing base (8690859) to head (0ee9eb3).
Report is 260 commits behind head on master.

Additional details and impacted files
Files with missing lines Coverage Δ
core/mapping/fieldoptions.go 100.00% <ø> (ø)
core/mapping/unmarshaler.go 96.18% <100.00%> (-0.31%) ⬇️
core/mapping/utils.go 100.00% <ø> (ø)

... and 7 files with indirect coverage changes

@kevwan kevwan merged commit f747585 into zeromicro:master Feb 8, 2025
@kevwan kevwan deleted the chore/refactor branch February 8, 2025 17:00
@xuerbujia
Copy link
Copy Markdown
Contributor

xuerbujia commented Feb 10, 2025

If simply remove the comma array, then some users who are using this feature in version 1.7.5-1.8.0 and who do not have the condition mentioned in #4629 will not be able to upgrade to a later version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants