Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove space in custom string literal #652

Merged
merged 1 commit into from
Mar 12, 2025
Merged

Conversation

MichaelChirico
Copy link
Contributor

I may lack sufficient context for this to be a useful PR, so please feel free to close if this is not welcome.

For no particular reason I saw an analogous PR to another R package repo in my GitHub home page:

marzer/tomlplusplus#263

I searched the main R package repo for other similarly-affected packages, which includes {clustermq}, which bundles this repo as a submodule:

https://github.com/mschubert/clustermq/tree/master/src

Here's the documentation I could find about why this matters:

https://en.cppreference.com/w/cpp/language/user_literal

// error: all names that begin with underscore followed by uppercase
// letter are reserved (NOTE: a space between "" and _).
double operator"" _Z(long double);

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13804398584

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.368%

Totals Coverage Status
Change from base Build 13540525397: 0.0%
Covered Lines: 849
Relevant Lines: 983

💛 - Coveralls

@gummif
Copy link
Member

gummif commented Mar 12, 2025

We probably need to modify the clang-format file/update clang-format so this doesn't get reverted, but this is fine for now.

@gummif gummif merged commit 21c83ca into zeromq:master Mar 12, 2025
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants