fix: restore shared libzmq builds - #737
Conversation
|
@aminya CI exposed two toolchain-drift failures on fresh builds:
I pushed a separate commit pinning vcpkg to the existing baseline and pnpm to the |
|
@aminya all jobs that obtained runners now pass. The remaining three stayed queued because I pushed |
|
@aminya I pushed All failure classes from run 31172168126 are resolved in the replacement platform jobs. Could you approve run 31254945575 to validate Package and SmokeTest? |
aminya
left a comment
There was a problem hiding this comment.
Thanks for your contribution and for fixing the CI matrix as well.
Summary
zmq_shared=truebuild option that existed before the CMake migrationlibzmqis requestedpkg-config.npmrcoptionVerification
Tested on macOS arm64 with Node 22.22.3, CMake 4.4.2, Ninja 1.13.2, pkgconf 3.0.5, and Homebrew
zeromq4.3.5_2:otool -Lconfirms the addon links/opt/homebrew/opt/zeromq/lib/libzmq.5.dylib. Requiring the package reports libzmq 4.3.5 and constructing/closing aPairsocket succeeds. Type checks and ESLint complete without errors; existing unrelated warnings remain.Fixes #736 and unblocks Homebrew/homebrew-core#297372.
@aminya please review the CMake path and publish a release after merge so downstream packaging can consume it.