Atom borders #897
Atom borders #897
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ): | ||
| line_style = { | ||
| "color": l_color, | ||
| "width": l_width, | ||
| "opacity": l_opacity, | ||
| "dash": l_dash, | ||
| } | ||
| marker_style = {"line_width": b_width, "line_color": b_color} | ||
| marker_style = {k: v for k, v in marker_style.items() if v is not None} |
Check warning
Code scanning / CodeQL
Variable defined multiple times Warning
There was a problem hiding this comment.
This is a CodeQL bug 😅
pfebrer
force-pushed
the
atom_borders
branch
from
b7c8656 to
64c8e58
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #897 +/- ##
==========================================
- Coverage 86.82% 86.82% -0.01%
==========================================
Files 405 405
Lines 53308 53314 +6
==========================================
+ Hits 46286 46290 +4
- Misses 7022 7024 +2 ☔ View full report in Codecov by Sentry. |
|
Now you'll be the Guinea pig of trying out the towncrier release notes, see in |
|
It is a bit strange because first you have to create the PR to know what is the number, and then you have to create an extra commit to add the file with the changes. Do you envision that then all the changes are squashed into a single commit? Or there will always be an individual commit for adding the change file? It complicates a bit the process of submitting a PR 😅 |
|
And now all tests are running again just because I added the change file 😅 Although I guess this could be easily fixed |
|
Maybe it would help to be able to write the file before with a name like Or the description of the change could be part of the initial PR comment here in github and picked up automatically when merging. That would be less of a burden for the PR submitter. |
Agreed, this also bothers me.
Likely that would be great.
Agreed... :(
I think this would be a good approach. I should look into this. |
Ok, I know why that happened. We do have a check for only changing py files. However, you force-pushed, meaning you created a new commit with changes in py files. If you had done a simple commit, only touching the |
|
Did I? I think the force push was before the commit that adds the change file. But maybe the tests didn't run, I just saw the CI run and assumed that the tests would run |
Hmm, yeah, I missed that... I have found the culprit. A GA runs if the |
Added the possibility to tweak atom borders in the plots with 2D views, using the
border_colorandborder_widthkeys.I added the border modification to the example notebook. A poll in Discord has determined that black borders should be the default so this is what I have done here.
I have also taken the opportunity to document the file that plots lines from xarray data, which is quite complex and was undocumented.