Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Makefile to properly include zvm.h #15

Open
larsbutler opened this issue Mar 4, 2014 · 2 comments
Open

Fix Makefile to properly include zvm.h #15

larsbutler opened this issue Mar 4, 2014 · 2 comments

Comments

@larsbutler
Copy link
Member

At the moment, we need to set CPATH=/usr/x86_64-nacl/include to build toolchain. This fix should probably be moved to the Makefile, per this comment: #14 (comment)

@pkit
Copy link
Member

pkit commented Mar 4, 2014

zvm.h is used by ZRT only (in the toolchain build)
I suppose Makefile or Makefile.env can be altered to use more proper paths.
Do all Linux distros use /usr as syspath?

@mgeisler
Copy link
Contributor

mgeisler commented Mar 5, 2014

Thanks @larsbutler for recording my comment as an issue — I should have done that directly...

@pkit I think the zrt Makefile.env should respect PREFIX instead of ZVM_PREFIX as I think it does today. That is, I see it doing:

ZVM_PREFIX_ABSPATH = $(abspath $(ZVM_PREFIX))
ZRT_INCLUDE_PATH= -I${ZVM_PREFIX_ABSPATH}/api \
-I${ZVM_PREFIX_ABSPATH}/x86_64-nacl/include \
-I${ZRT_ROOT}/lib \
# ...

The PREFIX variable isn't used and that's what the tools will set when building .deb and .rpm packages. We can of course also update the build tools to explicitly set ZVM_PREFIX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants