README: re-wrote build instructions, using pkgs #14
Conversation
Completely re-wrote and simplified the build instructions. The new instructions involve installation zerovm and zvm-validator from packages, instead of installing manually. NOTE: I removed the section which instructs the user to run zerovm tests by invoking `./ftests.sh` from the ZEROVM_ROOT. We need to figure out a good context in which to run these tests. They do require a working toolchain to function, but they are part of the zerovm repo (which is a prerequisite for building the toolchain), so there's kind of a catch 22 here that we need to think about. Perhaps it's best to move these tests to the toolchain repo.
| * `ZVM_PREFIX`: should point to an *empty writable directory* all | ||
| files will be installed here after `make install` | ||
| * `ZRT_ROOT`: should point to git clone of `zrt` repository | ||
| * `LD_LIBRARY_PATH`: library path for libvalidator.so (from | ||
| [zvm-validator](https://github.com/zerovm/validator)) | ||
| * `CPATH`: include directory containing `zvm.h` (from `zerovm-zmq-dev`) |
There was a problem hiding this comment.
Great that you could clean up the instructions!
We should look into this, though, since setting CPATH means that we're doing something wrong. If it worked before without setting it and now requires setting it, then one of our Makefiles is broken. The Makefile needs to add -I /usr/x86_64-nacl/include to the right compile command.
There was a problem hiding this comment.
Yeah, that makes sense. I opened an issue for this: #15
README: re-wrote build instructions, using pkgs
| @@ -94,16 +80,10 @@ Example of cleanup procedures: | |||
| cd $HOME/zvm-toolchain | |||
| make clean | |||
| cd $ZVM_PREFIX | |||
| rm -fr * | |||
| rm -rf * | |||
There was a problem hiding this comment.
This change looks like an unrelated change to me — it's not about using packages, it's fixing something else.
|
ftests.sh paragraph was added after people repeatedly cloned zerovm repo, happily built it, and then tried to run functional tests... |
|
@pkit Point taken. Perhaps once we have the toolchain bootstrapped and continuously packaged, we can include the |
|
I think it will look ugly any way. Last time I've checked most new platform builds were ugly as hell (Android anyone?) |
README: re-wrote build instructions, using pkgs
Completely re-wrote and simplified the build instructions. The new
instructions involve installation zerovm and zvm-validator from
packages, instead of installing manually.
NOTE: I removed the section which instructs the user to run zerovm tests
by invoking
./ftests.shfrom the ZEROVM_ROOT. We need to figure out agood context in which to run these tests. They do require a working
toolchain to function, but they are part of the zerovm repo (which is a
prerequisite for building the toolchain), so there's kind of a catch 22
here that we need to think about. Perhaps it's best to move these tests
to the toolchain repo.