fix: hotfix to unblock Solana inbound

[ws4charlie]

Description

• The current inbound impl asks for 4 accounts (signer pda system program gateway) when checking the deposit instruction which is not correct. Instead we should only ask for 3 account (signer pda system program).
• When zetaclient can't parse signer address from deposit instruction, the current impl will keep retrying and completely block the inbound. Instead we should skip the transaction if the signer can't be parsed due to accounts error (e.g. mismatch, not found).

How Has This Been Tested?

• Tested CCTX in localnet
• Tested in development environment
• Go unit tests
• Go integration tests
• Tested via GitHub Actions

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Base branches to auto review (1)

• develop

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 46.95%. Comparing base (bc9f419) to head (fb871d5).
Report is 1 commits behind head on release/v19.

Files	Patch %	Lines
zetaclient/chains/solana/observer/inbound.go	25.00%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@               Coverage Diff               @@
##           release/v19    #2778      +/-   ##
===============================================
- Coverage        46.96%   46.95%   -0.01%     
===============================================
  Files              484      484              
  Lines            31740    31738       -2     
===============================================
- Hits             14908    14904       -4     
- Misses           15942    15945       +3     
+ Partials           890      889       -1     

Files	Coverage Δ
e2e/runner/solana.go	0.00% <ø> (ø)
pkg/contracts/solana/gateway.go	0.00% <ø> (ø)
zetaclient/chains/solana/observer/inbound.go	41.84% <25.00%> (-1.94%)	⬇️

[brewmaster012]

LGTM