fix: register all interfaces in encoding config

[gartnera]

Fix #2827

We have these RegisterInterfaces() calls copy pasted everywhere. Someone should probably clean theses up, but it would be nice to get state exports unblocked in the short term.

Will need to backport to release/v19 and cut a 19.2.1

Summary by CodeRabbit

• New Features

  • Enhanced encoding configuration by registering multiple interfaces, improving module interoperability and clarity.

• Bug Fixes

  • Resolved issues related to interface registration that could affect functionality across various modules.

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

Walkthrough

The changes enhance the MakeEncodingConfig function in app/encoding.go by explicitly registering various interfaces from multiple packages. This replaces previously commented-out lines and ensures that all necessary interfaces, crucial for module interoperability, are properly registered. The function's signature remains unchanged, but the internal logic is now more robust.

Changes

Files	Change Summary
app/encoding.go	Updated MakeEncodingConfig to register multiple interfaces from various packages for improved functionality.

Assessment against linked issues

Objective	Addressed	Explanation
V19 mainnet state export fails (#2827)	✅
Ensure all necessary interfaces are registered (#2827)	✅

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ebeedfc and 9a92883.

Files selected for processing (1)

• app/encoding.go (1 hunks)

Additional context used

Path-based instructions (1)

app/encoding.go (1)

Pattern **/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.

Additional comments not posted (2)

app/encoding.go (2)

4-21: Import statements look good.

The added import statements are necessary for registering interfaces from the respective packages. They follow the standard Go syntax and naming conventions.

---

29-44: Interface registrations are comprehensive and well-structured.

The added interface registrations in the MakeEncodingConfig function are crucial for ensuring interoperability between modules. The registrations cover a wide range of packages, indicating a comprehensive approach. The code is clear, concise, and follows a logical order, grouping related packages together.