Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract MessagesPage data loading to dataAccess module #134

Merged
merged 2 commits into from
Oct 19, 2024

Conversation

richardolsson
Copy link
Member

This PR moves the data loading required for MessagesPage to the dataAccess module as a first step towards implementing cache revaliation. See issue #25 for game plan and motivations.

This is joint work by me and @WULCAN. We realized that further extraction and refactoring is possible, but chose not to do it now as it is not crucial for the cache issue, and can be done at a later point.

Copy link
Collaborator

@WULCAN WULCAN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know I was part of writing this but I feel pretty confident in my ability to review it well anyway.

I approve of merging these changes but leave it up to you to merge it, just in case you want a more independent review first.

@richardolsson richardolsson merged commit 2328532 into main Oct 19, 2024
1 check passed
@richardolsson richardolsson deleted the issue-25/extract-more-to-data-access branch October 19, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants