refactor: lazy-init ChatBot at LRCer level, share across files#117
Merged
MaleicAcid merged 1 commit intoApr 28, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
After PR #113 moved ChatBot creation from
LLMTranslatortoLRCer._translate(), each file translation still creates and destroys its own ChatBot (HTTP connection pool). Translating 10 files means 10 TLS handshakes and 10 connection teardowns to the same API endpoint.This PR lifts ChatBot lifecycle to the
LRCerinstance level using lazy initialization — the same pattern already used forTranscriber. ChatBot instances are created on first access and shared across all files processed by the sameLRCer.Changes
chatbotandretry_chatbotas lazy-initialized properties onLRCer, with thread-safe double-checked locking (consistent with the existingtranscriberproperty).close()method and context manager support (__enter__/__exit__) toLRCerfor explicit resource cleanup._translate(): removedExitStack/create_chatbot/_open_bothelper, now usesself.chatbotandself.retry_chatbotdirectly.README.md: fixed outdatedLLMTranslatorexample to use the newcreate_chatbot()+chatbot=API, and documented the newwith LRCer() as lrcer:usage pattern.Benefits
_translate(): no moreExitStack,create_chatbot, or_open_bothelper — justself.chatbot.with LRCer() as lrcer:guarantees connections are closed when done.transcribe()never pay the cost of establishing an LLM connection.