Repository navigation
fix(daemon): make wire publication context cancellation explicit - #293
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go 1.26 的 lostcancel 分析无法证明可变 cancel 函数经外层闭包在所有路径释放，导致全量
go vet ./...失败。将取消的 defer 紧跟在首次创建 wire-publication timeout context 后登记，保留只创建一次、有界只读回查、失败不重写的行为。原实现已有延迟取消，未确认真实泄漏；本改动明确取消函数的生命周期并消除静态检查失败。
验证：
GOMAXPROCS=2 go vet -p=1 ./...通过；GOMAXPROCS=2 go test -p=1 ./internal/daemon -run 'Geometry|WirePublication' -count=1通过。