Merge pull request #6 from apache/master

fetch remote

.asf.yaml

@@ -0,0 +1,81 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# https://cwiki.apache.org/confluence/display/INFRA/.asf.yaml+features+for+git+repositories
+---
+github:
+  description: "Apache Superset is a Data Visualization and Data Exploration Platform"
+  homepage: https://superset.apache.org/
+  labels:
+    - superset
+    - apache
+    - apache-superset
+    - data-visualization
+    - data-viz
+    - analytics
+    - business-intelligence
+    - data-science
+    - data-engineering
+    - asf
+    - bi
+    - business-analytics
+    - data-analytics
+    - data-analysis
+    - data-science
+    - python
+    - react
+    - sql-editor
+    - flask
+  features:
+    # Enable issues management
+    issues: true
+    # Enable projects for project management boards
+    projects: true
+    # Enable wiki for documentation
+    wiki: true
+
+  enabled_merge_buttons:
+    squash: true
+    merge: false
+    rebase: false
+
+  protected_branches:
+    master:
+      required_status_checks:
+        # strict means "Require branches to be up to date before merging".
+        strict: false
+        # contexts are the names of checks that must pass
+        contexts:
+          - check
+          - cypress-matrix (1, chrome)
+          - cypress-matrix (2, chrome)
+          - cypress-matrix (3, chrome)
+          - docker-build
+          - frontend-build
+          - pre-commit (3.8)
+          - python-lint (3.8)
+          - test-mysql (3.8)
+          - test-postgres (3.8)
+          - test-postgres (3.9)
+          - test-sqlite (3.8)
+
+      required_pull_request_reviews:
+        dismiss_stale_reviews: false
+        require_code_owner_reviews: true
+        required_approving_review_count: 1
+
+      required_signatures: false

.codecov.yml

@@ -1,11 +1,35 @@
+codecov:
+    notify:
+        after_n_builds: 4
+ignore:
+  - "superset/migrations/versions/*.py"
+  - "superset-frontend/packages/superset-ui-demo/**/*"
+  - "**/*.stories.tsx"
+  - "**/*.stories.jsx"
 coverage:
   status:
     project:
       default:
+        informational: true
         # Commits pushed to master should not make the overall
         # project coverage decrease:
         target: auto
         threshold: 0%
+      core-packages-ts:
+        target: 100%
+        paths:
+          - 'superset-frontend/packages'
+          - '!superset-frontend/packages/**/*.jsx'
+          - '!superset-frontend/packages/**/*.tsx'
+      core-packages-tsx:
+        target: 50%
+        paths:
+          - 'superset-frontend/packages/**/*.jsx'
+          - 'superset-frontend/packages/**/*.tsx'
     patch:
       default:
+        informational: true
         threshold: 0%
+flag_management:
+  default_rules:
+    carryforward: true

.dockerignore

@@ -15,6 +15,9 @@
 # limitations under the License.
 #
 **/__pycache__/
+**/.git
+**/.apache_superset.egg-info
+**/.github
 **/.mypy_cache
 **/.pytest_cache
 **/.tox
@@ -30,10 +33,15 @@
 **/*.pyc
 **/*.sqllite
 **/*.swp
+**/.terser-plugin-cache/
+**/.storybook/
+**/node_modules/
 
 tests/
 docs/
 install/
-superset/assets/node_modules/
-superset/assets/cypress/
-superset/assets/coverage/
+superset-frontend/cypress-base/
+superset-frontend/coverage/
+superset/static/assets/
+superset-websocket/dist/
+venv

.editorconfig

@@ -0,0 +1,47 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# EditorConfig is awesome: https://EditorConfig.org
+
+# top-most EditorConfig file
+root = true
+
+# Unix-style newlines with a newline ending every file
+[*]
+end_of_line = lf
+insert_final_newline = true
+charset = utf-8
+
+# 4 space indentation for Python files
+[*.py]
+indent_style = space
+indent_size = 4
+max_line_length=88
+
+# 2 space indentation for Frontend files
+[*.{js,jsx,ts,tsx,html,less,css}]
+indent_style = space
+indent_size = 2
+
+# 2 space indentation for json and yaml files
+[*.{json,yml}]
+indent_style = space
+indent_size = 2
+
+# Tab indentation
+[Makefile]
+indent_style = tab

.fossa.yml

@@ -26,13 +26,11 @@ analyze:
   modules:
   - name: assets
     type: npm
-    target: superset/assets
-    path: superset/assets
-  - name: docs
-    type: pip
-    target: docs
-    path: docs
-  - name: .
+    target: superset-frontend
+    path: superset-frontend
+  - name: base
     type: pip
     target: .
     path: .
+    options:
+      requirements: ./requirements/base.txt

.gitattributes

@@ -0,0 +1 @@
+docker/**/*.sh text eol=lf

.github/CODEOWNERS

@@ -0,0 +1,22 @@
+# Notify all committers of DB migration changes, per SIP-59
+
+# https://github.com/apache/superset/issues/13351
+
+/superset/migrations/ @apache/superset-committers
+
+# Notify Preset team when ephemeral env settings are changed
+
+.github/workflows/ecs-task-definition.json @robdiciuccio @craig-rueda @rusackas @eschutho @dpgaspar @nytai @mistercrunch
+.github/workflows/docker-ephemeral-env.yml @robdiciuccio @craig-rueda @rusackas @eschutho @dpgaspar @nytai @mistercrunch
+.github/workflows/ephemeral*.yml @robdiciuccio @craig-rueda @rusackas @eschutho @dpgaspar @nytai @mistercrunch
+
+# Notify some committers of changes in the Select component
+
+/superset-frontend/src/components/Select/ @michael-s-molina @geido @ktmud
+
+# Notify Helm Chart maintainers about changes in it
+
+/helm/superset/ @craig-rueda @dpgaspar @villebro
+
+# Notify E2E test maintainers of changes
+/superset-frontend/cypress-base/ @jinghua-qa

.github/ISSUE_TEMPLATE/bug_report.md

@@ -1,11 +1,19 @@
 ---
 name: Bug report
 about: Create a report to help us improve
+labels: "#bug"
 
 ---
 
 A clear and concise description of what the bug is.
 
+#### How to reproduce the bug
+
+1. Go to '...'
+2. Click on '....'
+3. Scroll down to '....'
+4. See error
+
 ### Expected results
 
 what you expected to happen.
@@ -18,25 +26,20 @@ what actually happens.
 
 If applicable, add screenshots to help explain your problem.
 
-#### How to reproduce the bug
-
-1. Go to '...'
-2. Click on '....'
-3. Scroll down to '....'
-4. See error
 
 ### Environment
 
 (please complete the following information):
 
+- browser type and version:
 - superset version: `superset version`
 - python version: `python --version`
 - node.js version: `node -v`
-- npm version: `npm -v`
+- any feature flags active:
 
 ### Checklist
 
-Make sure these boxes are checked before submitting your issue - thank you!
+Make sure to follow these steps before submitting your issue - thank you!
 
 - [ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
 - [ ] I have reproduced the issue with at least the latest released version of superset.

.github/ISSUE_TEMPLATE/cosmetic.md

@@ -0,0 +1,20 @@
+---
+name: Cosmetic Issue
+about: Describe a cosmetic issue with CSS, positioning, layout, labeling, or similar
+labels: "cosmetic-issue"
+
+---
+
+## Screenshot
+
+[drag & drop image(s) here!]
+
+## Description
+
+[describe the issue here!]
+
+## Design input
+[describe any input/collaboration you'd like from designers, and
+tag accordingly. For design review, add the
+label `design:review`. If this includes a design proposal,
+include the label `design:suggest`]

.github/ISSUE_TEMPLATE/feature_request.md

@@ -1,17 +1,14 @@
 ---
 name: Feature request
 about: Suggest an idea for this project
+labels: "#enhancement"
 
 ---
 
-**Is your feature request related to a problem? Please describe.**
-A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
+Github Discussions is our new home for discussing features and improvements!
 
-**Describe the solution you'd like**
-A clear and concise description of what you want to happen.
+https://github.com/apache/superset/discussions/categories/ideas
 
-**Describe alternatives you've considered**
-A clear and concise description of any alternative solutions or features you've considered.
+We'd like to keep Github Issues focuses on bugs and SIP's (Superset Improvement Proposals)!
 
-**Additional context**
-Add any other context or screenshots about the feature request here.
+Please note that feature requests opened as Github Issues will be moved to Discussions.

.github/ISSUE_TEMPLATE/sip.md

@@ -1,10 +1,14 @@
 ---
 name: SIP
 about: Superset Improvement Proposal
+labels: "#SIP"
 
 ---
 
-## [SIP] Proposal for XXX
+*Please make sure you are familiar with the SIP process documented*
+(here)[https://github.com/apache/superset/issues/5602]. The SIP number should be the next number after the latest SIP listed [here](https://github.com/apache/superset/issues?q=is%3Aissue+label%3Asip).
+
+## [SIP-\<number>] Proposal for <title>
 
 ### Motivation
 

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,31 +1,27 @@
-### CATEGORY
-
-Choose one
-
-- [ ] Bug Fix
-- [ ] Enhancement (new features, refinement)
-- [ ] Refactor
-- [ ] Add tests
-- [ ] Build / Development Environment
-- [ ] Documentation
+<!---
+Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
+Example:
+fix(dashboard): load charts correctly
+-->
 
 ### SUMMARY
 <!--- Describe the change below, including rationale and design decisions -->
 
 ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
 <!--- Skip this if not applicable -->
 
-### TEST PLAN
-<!--- What steps should be taken to verify the changes -->
+### TESTING INSTRUCTIONS
+<!--- Required! What steps can be taken to manually verify the changes? -->
 
 ### ADDITIONAL INFORMATION
 <!--- Check any relevant boxes with "x" -->
 <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
 - [ ] Has associated issue:
+- [ ] Required feature flags:
 - [ ] Changes UI
-- [ ] Requires DB Migration.
-- [ ] Confirm DB Migration upgrade and downgrade tested.
+- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
+  - [ ] Migration is atomic, supports rollback & is backwards-compatible
+  - [ ] Confirm DB migration upgrade and downgrade tested
+  - [ ] Runtime estimates and downtime expectations provided
 - [ ] Introduces new feature or API
 - [ ] Removes existing feature or API
-
-### REVIEWERS