Commented mnist_igor_two.py plus removed double parens in Ca_HVA.mod #6

igorpodolak · 2020-03-16T15:26:33Z

UPDATE:

In agents/agent.py and agents/ebner_agent.py corrected:

ebner_agent.py:_build_network():
input_syn_per_cell computed as an area resulting from the kernel ratio,
agent.py:_make_2d_observation():
corrected upper ranges for x and y to constitute for the case when stride < kernel_width

…nto models_igr

…red); marking of true/predicted classes (record.py), randomization of starting weights (ebner_agent.py)

…T, EPSILON); mnist_igor_two.py chooses one output"

ziemowit-s · 2020-03-23T14:07:53Z

agents/ebner_agent.py

-                           delay=1, netcon_weight=WEIGHT, ach_weight=1, da_weight=1, rule='all',
-                           ACh_tau=50, Da_tau=50)
+                           delay=1, netcon_weight=np.max((0, WEIGHT + np.random.normal(loc=0.0, scale=EPSILON))),
+                           ach_weight=1, da_weight=1, rule='all', ACh_tau=50, Da_tau=50)


I have doubt about netcon_weight to make it random - let's talk on the call

As of now, reject these modifications. It needs deeper tests.

ziemowit-s · 2020-03-23T14:08:44Z

mnist_igor_two.py

+    sys.exit(0)
+
+
+class EbOlAg(EbnerOlfactoryAgent):


Naming should be consistent with other Agents. So name it Ebner...Agent

Oh, I did not require the inclusion of mnist_igor_two.py into the master. It was only designed for you commenting on my comments whether I understood it correctly. And try some very minor changes into the architecture.
Nonetheless, the EbnerOlfactoryAgent() has some constants in it (numbers of hidden and inhibitory neurons) and it makes it harder to extend it easily.

OK, that's fine for now. but if you want me to comment on something - maybe the best way is to use Github Gist in the future: https://gist.github.com

ziemowit-s · 2020-03-24T09:54:26Z

mnist_igor_two.py

+    sys.exit(0)
+
+
+class EbOlAg(EbnerOlfactoryAgent):


OK, that's fine for now. but if you want me to comment on something - maybe the best way is to use Github Gist in the future: https://gist.github.com

# Conflicts: # agents/ebner_agent.py

ziemowit-s · 2020-03-24T10:12:51Z

mnist_igor_two.py

+        break
+if not found:
+    print("NEURON-7.7 path not found in sys.path; exiting")
+    sys.exit(0)


This not works for me (on Ubuntu)

ziemowit-s · 2020-03-24T10:13:47Z

mnist_igor_two.py

+            # info left AGENT_STEPSIZE / DT for additional steps on the left of display
+            agent.rec_output.plot(animate=True,
+                                  steps=int(AGENT_STEPSIZE / DT + 2 * display_interval * AGENT_STEPSIZE / DT),
+                                  true_class=last_true, pred_class=last_predicted, stepsize=AGENT_STEPSIZE, dt=DT)


This code requires changes to neuron++ so before we merge them - I can't merge this one to the gym repo

…gor_run is the latest try-on version of mnist

# Conflicts: # agents/agent.py

# Conflicts: # agents/agent.py # agents/ebner_agent.py

# Conflicts: # mnist_run.py # simple_run.py

… reading

…ent.py

# Conflicts: # agents/ebner_agent.py # mnist_run.py

…ent.py + mnist_igor_two.py

…nt: corrected input field calculation; ebner_olfactory_agent: extended init parameters; mnist_igor_two: rewritten + clear

# Conflicts: # agents/agent.py # agents/ebner_agent.py # mnist_igor_two.py

…nt: corrected input field calculation; ebner_olfactory_agent: extended init parameters; mnist_igor_two: rewritten + clear

pep8speaks · 2020-05-15T12:45:12Z

Hello @igorpodolak! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file agents/agent.py:

Line 31:80: E501 line too long (123 > 79 characters)
Line 87:80: E501 line too long (103 > 79 characters)
Line 89:80: E501 line too long (103 > 79 characters)
Line 110:80: E501 line too long (93 > 79 characters)
Line 111:80: E501 line too long (103 > 79 characters)
Line 115:80: E501 line too long (118 > 79 characters)
Line 120:80: E501 line too long (120 > 79 characters)
Line 162:80: E501 line too long (84 > 79 characters)
Line 173:80: E501 line too long (112 > 79 characters)
Line 193:80: E501 line too long (110 > 79 characters)
Line 235:80: E501 line too long (106 > 79 characters)
Line 260:80: E501 line too long (114 > 79 characters)
Line 328:80: E501 line too long (106 > 79 characters)
Line 331:80: E501 line too long (90 > 79 characters)
Line 332:80: E501 line too long (94 > 79 characters)
Line 338:80: E501 line too long (120 > 79 characters)
Line 352:80: E501 line too long (106 > 79 characters)
Line 421:80: E501 line too long (108 > 79 characters)
Line 422:80: E501 line too long (84 > 79 characters)

In the file agents/ebner_agent.py:

Line 23:80: E501 line too long (85 > 79 characters)

In the file agents/ebner_olfactory_agent.py:

Line 17:80: E501 line too long (120 > 79 characters)
Line 30:80: E501 line too long (98 > 79 characters)
Line 33:80: E501 line too long (85 > 79 characters)
Line 37:80: E501 line too long (120 > 79 characters)
Line 43:80: E501 line too long (122 > 79 characters)
Line 51:80: E501 line too long (116 > 79 characters)

In the file agents/sigma3_agent.py:

Line 28:80: E501 line too long (120 > 79 characters)

In the file mnist_igor_two.py:

Line 43:80: E501 line too long (98 > 79 characters)
Line 79:80: E501 line too long (104 > 79 characters)
Line 84:80: E501 line too long (83 > 79 characters)
Line 85:80: E501 line too long (84 > 79 characters)
Line 86:80: E501 line too long (94 > 79 characters)
Line 87:80: E501 line too long (94 > 79 characters)
Line 88:80: E501 line too long (94 > 79 characters)
Line 89:80: E501 line too long (93 > 79 characters)
Line 129:80: E501 line too long (108 > 79 characters)
Line 130:80: E501 line too long (87 > 79 characters)
Line 133:80: E501 line too long (102 > 79 characters)
Line 136:80: E501 line too long (87 > 79 characters)
Line 141:49: E741 ambiguous variable name 'l'
Line 144:80: E501 line too long (96 > 79 characters)
Line 147:26: E701 multiple statements on one line (colon)
Line 148:80: E501 line too long (113 > 79 characters)
Line 153:80: E501 line too long (118 > 79 characters)
Line 154:80: E501 line too long (84 > 79 characters)
Line 155:80: E501 line too long (91 > 79 characters)
Line 159:80: E501 line too long (108 > 79 characters)
Line 160:80: E501 line too long (87 > 79 characters)
Line 161:80: E501 line too long (102 > 79 characters)
Line 164:80: E501 line too long (87 > 79 characters)
Line 169:49: E741 ambiguous variable name 'l'
Line 172:80: E501 line too long (96 > 79 characters)
Line 175:26: E701 multiple statements on one line (colon)
Line 176:80: E501 line too long (113 > 79 characters)
Line 181:80: E501 line too long (90 > 79 characters)
Line 195:80: E501 line too long (108 > 79 characters)
Line 204:80: E501 line too long (102 > 79 characters)
Line 205:80: E501 line too long (81 > 79 characters)
Line 212:80: E501 line too long (86 > 79 characters)
Line 219:80: E501 line too long (104 > 79 characters)
Line 220:80: E501 line too long (81 > 79 characters)
Line 222:80: E501 line too long (83 > 79 characters)
Line 235:80: E501 line too long (96 > 79 characters)
Line 236:80: E501 line too long (94 > 79 characters)
Line 238:80: E501 line too long (81 > 79 characters)
Line 253:80: E501 line too long (93 > 79 characters)
Line 261:80: E501 line too long (103 > 79 characters)
Line 263:80: E501 line too long (109 > 79 characters)
Line 264:80: E501 line too long (114 > 79 characters)
Line 265:80: E501 line too long (100 > 79 characters)
Line 267:80: E501 line too long (82 > 79 characters)
Line 268:80: E501 line too long (82 > 79 characters)
Line 269:80: E501 line too long (99 > 79 characters)
Line 270:80: E501 line too long (100 > 79 characters)
Line 271:80: E501 line too long (103 > 79 characters)
Line 272:80: E501 line too long (105 > 79 characters)
Line 273:80: E501 line too long (115 > 79 characters)
Line 275:80: E501 line too long (87 > 79 characters)
Line 286:80: E501 line too long (89 > 79 characters)
Line 291:80: E501 line too long (111 > 79 characters)
Line 294:80: E501 line too long (114 > 79 characters)
Line 295:80: E501 line too long (94 > 79 characters)
Line 300:80: E501 line too long (112 > 79 characters)
Line 301:80: E501 line too long (108 > 79 characters)
Line 302:80: E501 line too long (92 > 79 characters)
Line 304:80: E501 line too long (112 > 79 characters)
Line 305:80: E501 line too long (108 > 79 characters)
Line 306:80: E501 line too long (102 > 79 characters)
Line 311:80: E501 line too long (118 > 79 characters)
Line 312:80: E501 line too long (98 > 79 characters)
Line 315:80: E501 line too long (114 > 79 characters)
Line 322:80: E501 line too long (110 > 79 characters)
Line 323:80: E501 line too long (108 > 79 characters)
Line 329:80: E501 line too long (96 > 79 characters)
Line 330:80: E501 line too long (89 > 79 characters)
Line 335:80: E501 line too long (87 > 79 characters)
Line 336:80: E501 line too long (88 > 79 characters)
Line 337:80: E501 line too long (88 > 79 characters)
Line 343:80: E501 line too long (106 > 79 characters)
Line 347:80: E501 line too long (88 > 79 characters)
Line 379:80: E501 line too long (109 > 79 characters)
Line 387:80: E501 line too long (83 > 79 characters)
Line 388:80: E501 line too long (115 > 79 characters)

In the file mnist_rl.py:

Line 7:80: E501 line too long (105 > 79 characters)
Line 20:80: E501 line too long (116 > 79 characters)
Line 22:80: E501 line too long (109 > 79 characters)
Line 23:80: E501 line too long (114 > 79 characters)
Line 24:80: E501 line too long (100 > 79 characters)
Line 27:80: E501 line too long (103 > 79 characters)
Line 28:80: E501 line too long (82 > 79 characters)
Line 29:80: E501 line too long (82 > 79 characters)
Line 30:80: E501 line too long (112 > 79 characters)
Line 32:80: E501 line too long (100 > 79 characters)
Line 33:80: E501 line too long (108 > 79 characters)
Line 39:80: E501 line too long (93 > 79 characters)
Line 49:80: E501 line too long (95 > 79 characters)
Line 51:80: E501 line too long (83 > 79 characters)
Line 53:80: E501 line too long (117 > 79 characters)
Line 81:80: E501 line too long (106 > 79 characters)
Line 82:80: E501 line too long (91 > 79 characters)
Line 91:80: E501 line too long (83 > 79 characters)
Line 103:80: E501 line too long (91 > 79 characters)
Line 111:80: E501 line too long (102 > 79 characters)
Line 112:80: E501 line too long (81 > 79 characters)
Line 119:80: E501 line too long (86 > 79 characters)
Line 127:80: E501 line too long (110 > 79 characters)
Line 128:80: E501 line too long (81 > 79 characters)
Line 130:80: E501 line too long (83 > 79 characters)
Line 143:80: E501 line too long (96 > 79 characters)
Line 144:80: E501 line too long (94 > 79 characters)
Line 146:80: E501 line too long (81 > 79 characters)
Line 161:80: E501 line too long (83 > 79 characters)
Line 162:80: E501 line too long (115 > 79 characters)

In the file mnist_rl_utils.py:

Line 8:80: E501 line too long (99 > 79 characters)
Line 37:80: E501 line too long (101 > 79 characters)
Line 56:80: E501 line too long (93 > 79 characters)
Line 61:80: E501 line too long (96 > 79 characters)
Line 95:80: E501 line too long (85 > 79 characters)
Line 100:80: E501 line too long (98 > 79 characters)
Line 136:80: E501 line too long (104 > 79 characters)
Line 141:80: E501 line too long (83 > 79 characters)
Line 142:80: E501 line too long (84 > 79 characters)
Line 143:80: E501 line too long (94 > 79 characters)
Line 144:80: E501 line too long (94 > 79 characters)
Line 145:80: E501 line too long (94 > 79 characters)
Line 146:80: E501 line too long (93 > 79 characters)

igorpodolak and others added 6 commits March 16, 2020 15:49

Commented mnist_igor_two.py plus removed double parens in Ca_HVA.mod

c7d8040

Merge branch 'master' of https://github.com/ziemowit-s/neuronpp_gym i…

8cda4fa

…nto models_igr

wip

53ecac7

Updated drawing of network (network_status_graph.py; vertically cente…

9685c07

…red); marking of true/predicted classes (record.py), randomization of starting weights (ebner_agent.py)

"agent.py in _add_modulatory() draws netconn_weight from Normal(WEIGH…

52d75e3

…T, EPSILON); mnist_igor_two.py chooses one output"

fetched and resolved conflicts

4a61955

ziemowit-s requested changes Mar 23, 2020

View reviewed changes

ziemowit-s approved these changes Mar 24, 2020

View reviewed changes

ziemowit-s added 2 commits March 24, 2020 11:03

Merge remote-tracking branch 'origin/models_igr'

24445f1

# Conflicts: # agents/ebner_agent.py

merged into current master

05d9647

ziemowit-s requested changes Mar 24, 2020

View reviewed changes

igorpodolak and others added 19 commits March 24, 2020 18:17

Corrected agent.py to select and display predictions vs true. mnist_i…

03e8ddd

…gor_run is the latest try-on version of mnist

"minor changes to mnist_igor_two"

197b5ff

Merge remote-tracking branch 'origin/master' into models_igr

ea4bbde

# Conflicts: # agents/agent.py

Merge remote-tracking branch 'origin/master' into models_igr

d951033

# Conflicts: # agents/agent.py # agents/ebner_agent.py

mnist_igor_two: added output layer inhibition to EbnerOlfactoryAgent

bd464ca

Merge remote-tracking branch 'origin/master' into models_igr

82e3b85

# Conflicts: # mnist_run.py # simple_run.py

agent.py, ebner_agent.py: corrected input region reading

41485d9

agent.py, ebner_agent.py: corrected input region area calculation and…

49cb08c

… reading

minor errors (due to tragic namedtuple)

92ca7fe

minor errors in inheritance in ebner_olfactory_agent.py from ebner_ag…

12d5dfc

…ent.py

Merge remote-tracking branch 'origin/master' into models_igr

4ce2100

# Conflicts: # agents/ebner_agent.py # mnist_run.py

minor errors in inheritance in ebner_olfactory_agent.py from ebner_ag…

b9faa7a

…ent.py + mnist_igor_two.py

mnist_igor_two: updated import of NetworkStatusGraph

d2f636e

agent.py: better answer selection with no sorting required; ebner_age…

e8ca169

…nt: corrected input field calculation; ebner_olfactory_agent: extended init parameters; mnist_igor_two: rewritten + clear

Merge remote-tracking branch 'origin/master' into models_igr

a40f716

minor fixes to mnist igor 2

f56b027

minor changes

526911b

agent.py: better answer selection with no sorting required; ebner_age…

6e8afdf

…nt: corrected input field calculation; ebner_olfactory_agent: extended init parameters; mnist_igor_two: rewritten + clear

Merge remote-tracking branch 'origin/master' into models_igr

5c9f8c5

igorpodolak added 4 commits April 2, 2020 15:35

Merge remote-tracking branch 'origin/models_igr' into models_igr

9289a2a

# Conflicts: # agents/agent.py # agents/ebner_agent.py # mnist_igor_two.py

agent.py: better answer selection with no sorting required; ebner_age…

7224df5

…nt: corrected input field calculation; ebner_olfactory_agent: extended init parameters; mnist_igor_two: rewritten + clear

agent.py: better answer selection with no sorting required; ebner_age…

869b757

…nt: corrected input field calculation; ebner_olfactory_agent: extended init parameters; mnist_igor_two: rewritten + clear

templates for RL learning

257bc94

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Commented mnist_igor_two.py plus removed double parens in Ca_HVA.mod #6

Commented mnist_igor_two.py plus removed double parens in Ca_HVA.mod #6

igorpodolak commented Mar 16, 2020 •

edited

Loading

ziemowit-s Mar 23, 2020

igorpodolak Mar 23, 2020

ziemowit-s Mar 23, 2020

igorpodolak Mar 23, 2020

ziemowit-s Mar 24, 2020

ziemowit-s Mar 24, 2020

ziemowit-s Mar 24, 2020

ziemowit-s Mar 24, 2020

pep8speaks commented May 15, 2020

Commented mnist_igor_two.py plus removed double parens in Ca_HVA.mod #6

Are you sure you want to change the base?

Commented mnist_igor_two.py plus removed double parens in Ca_HVA.mod #6

Conversation

igorpodolak commented Mar 16, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pep8speaks commented May 15, 2020

igorpodolak commented Mar 16, 2020 •

edited

Loading