-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cart_pole #7
base: master
Are you sure you want to change the base?
cart_pole #7
Conversation
# print(observation) | ||
obs,reward,done,info=env.step(action) | ||
# print(obs) | ||
obs = np.array([1,1,1,1])*100 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
obs from env is updated by a constant array, why?
for t in range(100): | ||
env_vis.append(env.render(mode='rgb_array')) | ||
# print(observation) | ||
obs,reward,done,info=env.step(action) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You update your own reward by env reward in each step, and only env reward goes to the agent.step() function
obs,reward,done,info=env.step(action) | ||
# print(obs) | ||
obs = np.array([1,1,1,1])*100 | ||
output_spikes_ms=agent.step(observation=abs(obs.reshape((2,2))), reward=reward) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with the new version of Agent - I think we should use:
- agent.reward_step() for reward only
- agent.step() for step only
No description provided.