Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): loosen sdk deps version range #88

Merged
merged 1 commit into from
Aug 28, 2024
Merged

fix(deps): loosen sdk deps version range #88

merged 1 commit into from
Aug 28, 2024

Conversation

Yohe-Am
Copy link
Collaborator

@Yohe-Am Yohe-Am commented Aug 25, 2024

Tightly specified versions will mess with with cargo's solver downstream possibly manifesting in a conflict or a duplicate library.

@Yohe-Am Yohe-Am requested a review from zifeo August 25, 2024 23:12
@Yohe-Am Yohe-Am marked this pull request as draft August 25, 2024 23:23
@Yohe-Am
Copy link
Collaborator Author

Yohe-Am commented Aug 25, 2024

So, Deno pinned their tokio to =1.36 prevent interop with anyone specifying higher. I was going to loosen the deps of lade but no, it's not the only one affected (had to fork process-wrap).

Metatype can just depend on this branch until deno increment to something compatible. Will close this PR once that day arrives.

@zifeo zifeo marked this pull request as ready for review August 26, 2024 12:15
@zifeo zifeo marked this pull request as draft August 26, 2024 12:15
@zifeo zifeo marked this pull request as ready for review August 28, 2024 07:55
@zifeo zifeo merged commit 9665c37 into main Aug 28, 2024
12 checks passed
@zifeo zifeo deleted the fix/loosen-deps branch August 28, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants