Add schemaVersion field into NOC/ICA and auxiliary models #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abdulbois
force-pushed
the
add-schemaVersion-into-NOC-models
branch
8 times, most recently
from
dbf904d
to
ba3318e
Compare
Abdulbois
force-pushed
the
add-schemaVersion-into-NOC-models
branch
4 times, most recently
from
4b7e72f
to
0e08a56
Compare
- Bump schemaVersion of PKI Distribution Point model - Add base64 format validation for OTAChecksum of Model Version model Signed-off-by: Abdulbois <[email protected]> Signed-off-by: Abdulbois <[email protected]>
Signed-off-by: Abdulbois <[email protected]> Signed-off-by: Abdulbois <[email protected]>
Abdulbois
force-pushed
the
add-schemaVersion-into-NOC-models
branch
2 times, most recently
from
c46dbb5
to
daaa356
Compare
akarabashov
reviewed
Jun 5, 2024
| @@ -13,12 +13,11 @@ const TypeMsgAddNocX509IcaCert = "add_noc_x_509_ica_cert" | |||
|
|
|||
| var _ sdk.Msg = &MsgAddNocX509IcaCert{} | |||
|
|
|||
| func NewMsgAddNocX509IcaCert(signer string, cert string, certSchemaVersion, schemaVersion uint32) *MsgAddNocX509IcaCert { | |||
| func NewMsgAddNocX509IcaCert(signer string, cert string, schemaVersion uint32) *MsgAddNocX509IcaCert { | |||
There was a problem hiding this comment.
It might be better to use the certSchemaVersion instead of schemaVersion to be consistent with the field name CertSchemaVersion in MsgAddNocX509IcaCert
akarabashov
approved these changes
Jun 5, 2024
Signed-off-by: Abdulbois <[email protected]> Signed-off-by: Abdulbois <[email protected]>
Abdulbois
force-pushed
the
add-schemaVersion-into-NOC-models
branch
from
daaa356
to
2cfde03
Compare
Abdulbois
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.