#547 Add new fields into Model entity #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abdulbois
force-pushed
the
#547-Add-new-fields-into-Model-entity
branch
14 times, most recently
from
6c7b66f
to
3bbf4b4
Compare
akarabashov
reviewed
Jun 5, 2024
| int32 enhancedSetupFlowOptions = 21 [(gogoproto.moretags) = "validate:\"omitempty,gte=0,lte=65535\""]; | ||
| string enhancedSetupFlowTCUrl = 22 [(gogoproto.moretags) = "validate:\"required_if=EnhancedSetupFlowOptions 0,omitempty,url,startsnotwith=http:,max=256\""]; | ||
| int32 enhancedSetupFlowTCRevision = 23 [(gogoproto.moretags) = "validate:\"required_if=EnhancedSetupFlowOptions 0,gte=0,lte=65535\""]; | ||
| string enhancedSetupFlowTCDigest = 24 [(gogoproto.moretags) = "validate:\"required_if=EnhancedSetupFlowOptions 0,omitempty\""]; |
There was a problem hiding this comment.
According to the documentation, the maximum length of this field is 128.
akarabashov
reviewed
Jun 5, 2024
| model.EnhancedSetupFlowTCUrl = msg.EnhancedSetupFlowTCUrl | ||
| model.EnhancedSetupFlowTCRevision = msg.EnhancedSetupFlowTCRevision | ||
| model.EnhancedSetupFlowTCDigest = msg.EnhancedSetupFlowTCDigest | ||
| model.EnhancedSetupFlowTCFileSize = msg.EnhancedSetupFlowTCFileSize |
There was a problem hiding this comment.
The EnhancedSetupFlowTCFileSize field can only be set if EnhancedSetupFlowOptions is present.
akarabashov
reviewed
Jun 5, 2024
| model.EnhancedSetupFlowTCDigest = msg.EnhancedSetupFlowTCDigest | ||
| model.EnhancedSetupFlowTCFileSize = msg.EnhancedSetupFlowTCFileSize | ||
| model.MaintenanceUrl = msg.MaintenanceUrl | ||
| } |
There was a problem hiding this comment.
Maybe we should reset these fields when EnhancedSetupFlowOptions is set?
Abdulbois
force-pushed
the
#547-Add-new-fields-into-Model-entity
branch
from
3bbf4b4
to
c7aaa1f
Compare
Signed-off-by: Abdulbois <[email protected]> Signed-off-by: Abdulbois <[email protected]>
Abdulbois
force-pushed
the
#547-Add-new-fields-into-Model-entity
branch
from
c7aaa1f
to
f9492ab
Compare
akarabashov
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.