Fixed crash in posix.open when TMPFILE=true and DIRECTORY=false #20387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I saw some disabled tests in this file, due to #14968. Also the tests are currently only run for linux, which is overly restrictive, but I'm not entirely sure how to only enable the tests for the platforms that have .O flags, smth like @hasDecl(posix, "O") does no work, as O is defined for these, but is instead "cough" via a compileError prong. The "last resort" i guess would be to just list the relevant posix platforms manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20378.
As said in the issue, I think it would also be reasonable to solve this via returning an error instead.