std.Build: add search prefix "exact" variant #22552
Open
+130
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BratishkaErik
force-pushed
the
search-prefix-exact
branch
from
ffd95f4 to
47c69de
Compare
|
aarch64-linux-debug failure seems to be a regular |
BratishkaErik
force-pushed
the
search-prefix-exact
branch
from
47c69de to
d759b1e
Compare
Signed-off-by: Eric Joldasov <[email protected]>
…nd option
This allows more granurality when adding search pathes for cross-compiling.
By default old (all variant) system added `bin`, `include` and `lib`
subdirectories from `search-prefix` argument path when cross-compiling,
but on some distros it's not correct and can lead to some errors.
For example, on my Gentoo system I have libcurl installed as both
32-bit and 64-bit versions, which are located in `/usr/lib` and `/usr/lib64`
directories respectively. If I use plain `--search-prefix`, it fails
because it tries to add 32-bit libraries:
```console
$ zig build -Dtarget=x86_64-linux-gnu.2.35 --search-prefix /usr/
install
└─ install true_or_false
└─ zig build-exe true_or_false Debug x86_64-linux.6.11.7-gnu.2.40 3 errors
error: ld.lld: /usr/lib/libcurl.so is incompatible with elf_x86_64
error: ld.lld: /usr/lib/libssl.so is incompatible with elf_x86_64
error: ld.lld: /usr/lib/libcrypto.so is incompatible with elf_x86_64
```
Another example is `libgccjit` library, which shared objects are located
(at least on my system) in `/usr/lib/gcc/x86_64-pc-linux-gnu/14/`, and
include files in include subdir there. One solution I used recently
was to create temporary directory and symlink files so that they have
names expected by Zig, but it's not the best solution.
With this PR you can now supply file which will instruct build system
to add pathes written there as-is, without trying to guess subdirs there.
Something like:
```zig
.{
.libraries = "/usr/lib64",
}
```
or
```zig
.{
.binaries = "/usr/x86_64-pc-linux-gnu/gcc-bin/14/",
.libraries = "/usr/lib/gcc/x86_64-pc-linux-gnu/14",
.includes = "/usr/lib/gcc/x86_64-pc-linux-gnu/14/include/",
}
```
can be saved in some file like paths.zon and then passed using
`--search-prefix-exact paths.zon`. This also helps to use this config
on a system (distro) level, without messing with build.zig.
Signed-off-by: Eric Joldasov <[email protected]>
alexrp
force-pushed
the
search-prefix-exact
branch
from
d759b1e to
836795d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows more granurality when adding search pathes for cross-compiling. By default old (
allvariant) system addedbin,includeandlibsubdirectories fromsearch-prefixargument path when cross-compiling, but on some distros it's not correct and can lead to some errors.For example, on my Gentoo system I have
libcurlinstalled as both 32-bit and 64-bit versions, which are located in/usr/liband/usr/lib64directories respectively. If I use plain--search-prefix, it fails because it tries to add 32-bit libraries:Another example is
libgccjitlibrary, which shared objects are located (at least on my system) in/usr/lib/gcc/x86_64-pc-linux-gnu/14/, and include files inincludesubdir there. One solution I used recently was to create temporary directory and symlink files so that they have names expected by Zig, but it's not the best solution.With this PR you can now supply file which will instruct build system to add pathes written there as-is, without trying to guess subdirs there. Something like:
.{ .libraries = "/usr/lib64", }or
.{ .binaries = "/usr/x86_64-pc-linux-gnu/gcc-bin/14/", .libraries = "/usr/lib/gcc/x86_64-pc-linux-gnu/14", .includes = "/usr/lib/gcc/x86_64-pc-linux-gnu/14/include/", }can be saved in some file like
paths.zonand then passed using--search-prefix-exact paths.zon. This also helps to use this config on a system (distro) level, without messing with build.zig.