sema: coerce comptime known arguments earlier for @min
@max
#25296
+34
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently an assertion fails when trying to compile code like the following.
As far as I can see, this happens because in
sema.analyzeMinMax
no source location is given to the coercion ofstd.math.maxInt(u32)
to the result type (f32
). Becausestd.math.maxInt(u32)
isn't representable as anf32
without rounding, this will throw an error. The error code then asserts that there is a source location, which, as said before, there is not.I fixed this by coercing the comptime known arguments a bit earlier, with a source location given.
Also I removed the coercion of the comptime known argument(s) to
intermediate_scalar_ty
later on, because they are already guarantied to be coerced into it.fixes #25284