Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmarking methodology
Performance based on a micro-benchmark compiled with zig nightly build
0.16.0-dev.1234+74900e938on ReleaseFast. Specificallyzig build-exe bench.zig --name name -O ReleaseFast --zig-lib-dir lib.The new impl was compiled with the standard library of da48ade while the old impl was compiled with the standard library of 416bf1d.
The 'small' category is values of at most 7 bits, the 'medium' category is values of at most 12 bits and the 'full' category is values of
@bitSizeOf(T)bits.For both datasets the benchmark was run after a system reboot and 2 full warmup runs.
Rewrite
writeLeb128to no longer usewriteMultipleOf7Leb128, instead:Rewrite
Reader.takeLeb128to not usetakeMultipleOf7Leb128, instead:Writing performance:
margin or error or slightly faster.
Reading performance:
performance improvement.
margin or error or slightly faster.