-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Aqara Ceiling Light T1M (acn032) #3070
base: dev
Are you sure you want to change the base?
Conversation
This quirk adds support for power on behavior configuration
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3070 +/- ##
==========================================
+ Coverage 87.91% 87.93% +0.01%
==========================================
Files 301 301
Lines 9229 9244 +15
==========================================
+ Hits 8114 8129 +15
Misses 1115 1115 ☔ View full report in Codecov by Sentry. |
Also I think it would be nice to expose this option as a configuration entity in UI preferably in as a drop-down. Can anyone point me into an relevant example? |
Convert the quirk to v2 like this |
@corvis might be outside the scope of this PR, but it would be awesome if the ring light effects could also be exposed. I saw some indications this may be already be available in Zigbee2MQTT |
I do not have capacity to reverse engineer the protocol but if there is already a working solution in Zigbee2MQTT or any other project i can back port it in ZHA. @jrseliga can you point me into the code\PR\whatever else indications you've mentioned? |
@corvis the Make It Work Youtube channel reviewed the Aqara T1M. There was a brief mention of using this device with Zigbee2MQTT. He mentioned it was not reliable, but you will notice the effects dropdown at the the bottom. That link is right at the timestamp where he discusses Zigbee2MQTT with the Aqara T1M. I had a look through Zigbee2MQTT repository but couldn't pinpoint what may be exposing that specific feature. |
Any chance of this getting merged any time soon? I would love to be able to set my ceiling lights to PreserveState on power restoration. |
PROFILE_ID: zha.PROFILE_ID, | ||
DEVICE_TYPE: zha.DeviceType.COLOR_DIMMABLE_LIGHT, | ||
INPUT_CLUSTERS: [ | ||
BasicCluster.cluster_id, # 0x0000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove these comments at the end everywhere? We don't really use them in our repo and it should be kept consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And yeah, if this were a v2 quirk, we can directly add the config entity.
There's some docs in a draft PR.
I would love to know this too. My support request to Aqara told me to buy a hub to get this feature. This may be off-topic, but forgive my lack of knowledge: when this is merged into zigpy:dev, how long does it take to make into the mainline prod? I.e. will it take a couple of months before it’s in the regular updates, or would it be quicker for me to learn how to make a custom quirk? (I don’t want to buy more equipment unless I have to) Thanks, all! |
Proposed change
This quirk adds support for power on behavior configuration to Aqara Light T1M (ceiling light with RGB ring).
This device identifies itself as lumi.light.acn032.
Additional information
Resolves #3066
Checklist
pre-commit
checks pass / the code has been formatted using Black