Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Tuya 2 gang relay _TZ3000_m8f3z8ju #3113

Merged
merged 8 commits into from
Aug 26, 2024

Conversation

peper0
Copy link
Contributor

@peper0 peper0 commented Apr 17, 2024

Proposed change

Additional information

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

@TheJulianJES TheJulianJES added the Tuya Request/PR regarding a Tuya device label Apr 21, 2024
zhaquirks/tuya/ts000f_switch.py Outdated Show resolved Hide resolved
zhaquirks/tuya/ts000f_switch.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jun 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.27%. Comparing base (24217a3) to head (d1bec69).
Report is 34 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3113      +/-   ##
==========================================
+ Coverage   88.10%   88.27%   +0.16%     
==========================================
  Files         299      302       +3     
  Lines        9358     9447      +89     
==========================================
+ Hits         8245     8339      +94     
+ Misses       1113     1108       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheJulianJES TheJulianJES changed the title Add support for 2 gang relay TS000F from _TZ3000_m8f3z8ju Add support for Tuya 2 gang relay _TZ3000_m8f3z8ju Aug 3, 2024
@TheJulianJES TheJulianJES added the needs review This PR should be reviewed soon label Aug 3, 2024
zhaquirks/tuya/ts000f_switch.py Outdated Show resolved Hide resolved
zhaquirks/tuya/ts000f_switch.py Outdated Show resolved Hide resolved
zhaquirks/tuya/ts000f_switch.py Outdated Show resolved Hide resolved
zhaquirks/tuya/ts000f_switch.py Outdated Show resolved Hide resolved
Most of these had endpoint=242, so seem to be incorrect. They're not important anyway, so removing them.
Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be fine. Thanks!

@TheJulianJES TheJulianJES added smash This PR is close to be merged soon and removed needs review This PR should be reviewed soon labels Aug 26, 2024
zhaquirks/tuya/ts000f_switch.py Outdated Show resolved Hide resolved
zhaquirks/tuya/ts000f_switch.py Outdated Show resolved Hide resolved
zhaquirks/tuya/ts000f_switch.py Outdated Show resolved Hide resolved
zhaquirks/tuya/ts000f_switch.py Outdated Show resolved Hide resolved
zhaquirks/tuya/ts000f_switch.py Outdated Show resolved Hide resolved
zhaquirks/tuya/ts000f_switch.py Outdated Show resolved Hide resolved
@TheJulianJES TheJulianJES merged commit daef394 into zigpy:dev Aug 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
smash This PR is close to be merged soon Tuya Request/PR regarding a Tuya device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants