Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ty0201 to TuyaLocalCluster #3231

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

Update ty0201 to TuyaLocalCluster #3231

wants to merge 1 commit into from

Conversation

vJan00
Copy link

@vJan00 vJan00 commented Jun 26, 2024

Proposed change

I reviewed the ty0201.py and it didnt work on my TY0201 _TZ3000_bjawzodf.
So i reworked it to use the TuyaLocalCluster instead of TuyaAirQuality, which is way more stable.
Additonaly i added the TuyaPowerConfigurationCluster2AAA because the TY0201 _TZ3000_bjawzodf does get powered by 2x AAA Batteries.

Additional information

This is a rework of #3201 and it fixes #2862, fixes #2851 , fixes #2701 and fixes #3230 .

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.18%. Comparing base (8317dc6) to head (1956e57).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3231   +/-   ##
=======================================
  Coverage   88.18%   88.18%           
=======================================
  Files         301      301           
  Lines        9412     9413    +1     
=======================================
+ Hits         8300     8301    +1     
  Misses       1112     1112           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheJulianJES TheJulianJES added the Tuya Request/PR regarding a Tuya device label Jul 5, 2024
Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revert the formatting changes?
Also, unfortunately, this seems like it needs to be rebased on top of dev (or merge dev into your branch).

@TheJulianJES TheJulianJES marked this pull request as draft August 26, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tuya Request/PR regarding a Tuya device
Projects
None yet
2 participants