Skip to content

Do not store vector data in source, fixed compatible issue of latest version of opensearch-py #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −5
Open

Do not store vector data in source, fixed compatible issue of latest version of opensearch-py #613

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions vectordb_bench/backend/clients/aws_opensearch/aws_opensearch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,6 @@ def _create_index(self, client: OpenSearch) -> None:
# Prepare vector field configuration
vector_field_config = {
"type": "knn_vector",
"store": True,
"dimension": self.dim,
"method": method_config,
}
Expand Down Expand Up @@ -219,7 +218,7 @@ def _insert_with_single_client(
insert_data.append(other_data)

try:
self.client.bulk(insert_data)
self.client.bulk(body=insert_data)
return len(embeddings), None
except Exception as e:
log.warning(f"Failed to insert data: {self.index_name} error: {e!s}")
Expand Down Expand Up @@ -269,7 +268,7 @@ def insert_chunk(client_idx: int, chunk_idx: int):
insert_data.append(other_data)

try:
resp = client.bulk(insert_data)
resp = client.bulk(body=insert_data)
log.info(f"Client {client_idx} added {len(resp['items'])} documents")
return len(chunk_embeddings), None
except Exception as e:
Expand Down Expand Up @@ -302,7 +301,7 @@ def insert_chunk(client_idx: int, chunk_idx: int):
time.sleep(10)
return self._insert_with_single_client(embeddings, metadata)

resp = self.client.indices.stats(self.index_name)
resp = self.client.indices.stats(index=self.index_name)
log.info(
f"""Total document count in index after parallel insertion:
{resp['_all']['primaries']['indexing']['index_total']}""",
Expand Down Expand Up @@ -489,7 +488,7 @@ def _do_force_merge(self):
cluster_settings_body = {
"persistent": {"knn.algo_param.index_thread_qty": self.case_config.index_thread_qty_during_force_merge}
}
self.client.cluster.put_settings(cluster_settings_body)
self.client.cluster.put_settings(body=cluster_settings_body)

log.info("Updating the graph threshold to ensure that during merge we can do graph creation.")
output = self.client.indices.put_settings(
Expand Down