Skip to content

Conversation

@morning-color
Copy link

Tencent ES is not merely a vector database; it offers a more comprehensive one-stop AI search solution, surpassing the scope of single-point solutions provided by traditional vector databases. Its capabilities include but are not limited to document parsing, text chunking, embedding, model reranking, and LLM integration.
Welcome to experience: https://cloud.tencent.com/product/es .

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: morning-color
To complete the pull request process, please assign xuanyang-cn after the PR has been reviewed.
You can assign the PR to them by writing /assign @xuanyang-cn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Collaborator

@alwayslove2013 alwayslove2013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work on this pull request! We really appreciate your contribution to the community!

SECONDS_WAITING_FOR_FORCE_MERGE_API_CALL_SEC = 30


class TencentElasticsearch(VectorDB):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've noticed that the code here is very similar to the one for ElasticCloud. You can try to directly inherit from the ElasticCloud class and override any operations that are different. For specific practices, you can refer to

class AliyunElasticsearch(ElasticCloud):
def __init__(
self,
dim: int,
db_config: dict,
db_case_config: ElasticCloudIndexConfig,
indice: str = "vdb_bench_indice", # must be lowercase
id_col_name: str = "id",
vector_col_name: str = "vector",
drop_old: bool = False,
**kwargs,
):
super().__init__(
dim=dim,
db_config=db_config,
db_case_config=db_case_config,
indice=indice,
id_col_name=id_col_name,
vector_col_name=vector_col_name,
drop_old=drop_old,
**kwargs,
)

)


class TencentElasticsearchTypedDict(CommonTypedDict):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if this CLI tool could support ElasticCloud, AliyunES, and TencentES. Otherwise, no rush—I can handle it in a follow-up PR.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made the TencentElasticsearch client class directly inherit from the ElasticCloud class.
Sorry, I haven't made changes to the CLI tool because I don't have test resources for ElasticCloud or AliyunES, and I'm unsure if the modifications will work properly. Could you merge my PR first, and then merge the CLI tool changes later?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants