-
Notifications
You must be signed in to change notification settings - Fork 277
Add TencentES client #623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add TencentES client #623
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: morning-color The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
alwayslove2013
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work on this pull request! We really appreciate your contribution to the community!
| SECONDS_WAITING_FOR_FORCE_MERGE_API_CALL_SEC = 30 | ||
|
|
||
|
|
||
| class TencentElasticsearch(VectorDB): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've noticed that the code here is very similar to the one for ElasticCloud. You can try to directly inherit from the ElasticCloud class and override any operations that are different. For specific practices, you can refer to
VectorDBBench/vectordb_bench/backend/clients/aliyun_elasticsearch/aliyun_elasticsearch.py
Lines 5 to 26 in cdd2a1e
| class AliyunElasticsearch(ElasticCloud): | |
| def __init__( | |
| self, | |
| dim: int, | |
| db_config: dict, | |
| db_case_config: ElasticCloudIndexConfig, | |
| indice: str = "vdb_bench_indice", # must be lowercase | |
| id_col_name: str = "id", | |
| vector_col_name: str = "vector", | |
| drop_old: bool = False, | |
| **kwargs, | |
| ): | |
| super().__init__( | |
| dim=dim, | |
| db_config=db_config, | |
| db_case_config=db_case_config, | |
| indice=indice, | |
| id_col_name=id_col_name, | |
| vector_col_name=vector_col_name, | |
| drop_old=drop_old, | |
| **kwargs, | |
| ) |
| ) | ||
|
|
||
|
|
||
| class TencentElasticsearchTypedDict(CommonTypedDict): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great if this CLI tool could support ElasticCloud, AliyunES, and TencentES. Otherwise, no rush—I can handle it in a follow-up PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made the TencentElasticsearch client class directly inherit from the ElasticCloud class.
Sorry, I haven't made changes to the CLI tool because I don't have test resources for ElasticCloud or AliyunES, and I'm unsure if the modifications will work properly. Could you merge my PR first, and then merge the CLI tool changes later?
Tencent ES is not merely a vector database; it offers a more comprehensive one-stop AI search solution, surpassing the scope of single-point solutions provided by traditional vector databases. Its capabilities include but are not limited to document parsing, text chunking, embedding, model reranking, and LLM integration.
Welcome to experience: https://cloud.tencent.com/product/es .