Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused fakeMessage helper methods #8

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

stewartboyd119
Copy link
Member

  1. Remove unused fakeMessage helper methods (leave and deprecate the popular zillow one)1
  2. Remove unused benchmark
  3. Remove zgkafka specific headers (rely on composition root for enterprise specific headers)

…popular zillow one)

1. Remove unused benchmark
1. Remove zgkafka specific headers (rely on composition root for enterprise specific headers)
@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 89.39394% with 7 lines in your changes missing coverage. Please review.

Project coverage is 93.19%. Comparing base (7935b74) to head (e3ced13).

Files Patch % Lines
testhelper.go 88.09% 3 Missing and 2 partials ⚠️
message.go 91.30% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
- Coverage   93.78%   93.19%   -0.60%     
==========================================
  Files          17       17              
  Lines        1288     1278      -10     
==========================================
- Hits         1208     1191      -17     
- Misses         52       56       +4     
- Partials       28       31       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stewartboyd119 stewartboyd119 merged commit 80b69cb into main Jul 24, 2024
2 checks passed
@stewartboyd119 stewartboyd119 deleted the update-fake-message-helpers branch July 24, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants