Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zio-prelude v1.0.0 - Roadmap #1359

Open
guizmaii opened this issue Aug 15, 2024 · 6 comments
Open

zio-prelude v1.0.0 - Roadmap #1359

guizmaii opened this issue Aug 15, 2024 · 6 comments

Comments

@guizmaii
Copy link
Member

guizmaii commented Aug 15, 2024 •
edited
Loading

@sideeffffect @kyri-petrou @jdegoes @ghostdogpr, please add anything you think we should fix/improve/change before releasing v1.0.0. Feel free to disagree with my points, of course 🙂

List of things to fix/improve/change before to release v1.0.0:

    • ZValidation.zipPar (and all the associated variants) are not parallelizing anything. They need to be renamed .zip.
    • Inconsistent usage of the "par fish" operators (aka <& & &>).
      in ZIO, a &> b mean that a and b will be forked.
      In zio-prelude ZValidation, they are not forking anything and just aliases for .zip (Related to point 2 of this ticket)
      Do we have the same issue anywhere else in zio-prelude? 🤔

Edit: Point 1. and 2. took into account in #1433
@guizmaii guizmaii mentioned this issue Aug 15, 2024
Merged
@guizmaii guizmaii changed the title zio-prelude 1.0.0 - Roadmap zio-prelude v1.0.0 - Roadmap Aug 15, 2024
@sideeffffect
Copy link
Member

sideeffffect commented Aug 15, 2024 •
edited
Loading

Looks good to me! Thanks for the initiative.
I'd like to get this merged (and have the linked PRs closed as deprecated):

@kyri-petrou
Copy link
Contributor

There is only one thing that comes to mind but I'm not sure whether it's even possible without a very major refactoring.

The ForEach type-class is defined as:

trait ForEach[F[+_]] extends Covariant[F]

This means that we can't provide ForEach instances for invariant types. A usecase where this is problematic, I wanted to use zio-prelude with doobie's Connection (which is Invariant) and wasn't able to because the compiler doesn't allow it.

@jivanic-demystdata
Copy link

@jdegoes Any thoughts about @kyri-petrou's Covariant issue?

@kyri-petrou
Copy link
Contributor

kyri-petrou commented Aug 16, 2024 •
edited
Loading

PS: I don't think we should try to address this for the v1 release. I just thought to point it out in case someone might have a simple solution in mind that wouldn't require a huge rewrite of the typeclass hierarchies

guizmaii added a commit that referenced this issue Dec 22, 2024
@guizmaii
Towards 1.0.0: Deprecate all the Validation operator using or imp…
28c6b48 
…lying "parallelization" in their names

zio-prelude `1.0.0` roadmap: #1359

- `&>` deprecated in favour of `*>`
- `<&` deprecated in favour of `<*`
- `<&>` deprecated in favour of `<*>`
- `toZIOParallelErrors` deprecated in favour of `toZIOAccumErrors`
- `zipParLeft` deprecated in favour of `zipLeft`
- `zipParRight` deprecated in favour of `zipRight`
- `zipPar` deprecated in favour of `zip`
- `zipWithPar` deprecated in favour of `zipWith`
guizmaii added a commit that referenced this issue Dec 22, 2024
@guizmaii
Towards 1.0.0: Deprecate all the Validation operator using or imp…
97809b4 
…lying "parallelization" in their names

zio-prelude `1.0.0` roadmap: #1359

- `&>` deprecated in favour of `*>`
- `<&` deprecated in favour of `<*`
- `<&>` deprecated in favour of `<*>`
- `toZIOParallelErrors` deprecated in favour of `toZIOAccumErrors`
- `zipParLeft` deprecated in favour of `zipLeft`
- `zipParRight` deprecated in favour of `zipRight`
- `zipPar` deprecated in favour of `zip`
- `zipWithPar` deprecated in favour of `zipWith`
guizmaii added a commit that referenced this issue Dec 22, 2024
@guizmaii
Towards 1.0.0: Deprecate all the ZValidation operators using or i…
72c6b17 
…mplying "parallelisation" in their names

zio-prelude `1.0.0` roadmap: #1359

- `&>` deprecated in favour of `*>`
- `<&` deprecated in favour of `<*`
- `<&>` deprecated in favour of `<*>`
- `toZIOParallelErrors` deprecated in favour of `toZIOAccumErrors`
- `zipParLeft` deprecated in favour of `zipLeft`
- `zipParRight` deprecated in favour of `zipRight`
- `zipPar` deprecated in favour of `zip`
- `zipWithPar` deprecated in favour of `zipWith`
@guizmaii guizmaii mentioned this issue Dec 22, 2024
Open
guizmaii added a commit that referenced this issue Dec 22, 2024
@guizmaii
Towards 1.0.0: Deprecate all the Validation operator using or imp…
08a37d7 
…lying "parallelization" in their names

zio-prelude `1.0.0` roadmap: #1359

- `&>` deprecated in favour of `*>`
- `<&` deprecated in favour of `<*`
- `<&>` deprecated in favour of `<*>`
- `toZIOParallelErrors` deprecated in favour of `toZIOAccumErrors`
- `zipParLeft` deprecated in favour of `zipLeft`
- `zipParRight` deprecated in favour of `zipRight`
- `zipPar` deprecated in favour of `zip`
- `zipWithPar` deprecated in favour of `zipWith`
@guizmaii
Copy link
Member Author

zio.prelude.CommutativeBoth.mapN combines the two provided F in parallel. Shouldn't we rename this function mapParN? 🤔

image

@sideeffffect
Copy link
Member

Yes! Good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@guizmaii @sideeffffect @kyri-petrou @jivanic-demystdata