-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZValidation#orElse
and ZValidation#orElseLog
parameter must be lazy
#1356
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change isn't binary compatible. I guess we're OK with that while we're in RC versions?
What happened to making a 1.0 by the way 🤣 |
@ghostdogpr @kyri-petrou (I really don't know much about bin-compat) |
As long as the library is in RC mode, there are no guarantees. But I think cutting a 1.0 would be nice to give those guarantees and maybe allow for a more widespread usage in libraries. |
Last time I talked about this with Adam, he was telling me that him and @jdegoes wanted to rework the typeclass hierarchy before to do that. John, any news about that? What was the idea/plan? |
Agreed Do we want to have a review of the code before releasing 1.0 tho? |
FYI, I started a ticket to list all the things we need to fix/change before Please help me listing all these things 🙏 |
Do we want to implement tests for this change?