fix: use html/template for SAML POST/Logout templates (#32)

* use html/template for SAML POST/Logout templates * fix: xml html header breaks in post/logoutTemplate when using html/template
zitadel · Nov 2, 2022 · e9cc5c7 · e9cc5c7
1 parent 80e4820
commit e9cc5c7
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/pkg/provider/identityprovider.go b/pkg/provider/identityprovider.go
@@ -9,7 +9,7 @@ import (
 	"io"
 	"net/http"
 	"reflect"
-	"text/template"
+	"html/template"
 	"time"
 
 	"github.com/zitadel/saml/pkg/provider/serviceprovider"

diff --git a/pkg/provider/logout_response.go b/pkg/provider/logout_response.go
@@ -6,7 +6,7 @@ import (
 	"encoding/base64"
 	"encoding/xml"
 	"net/http"
-	"text/template"
+	"html/template"
 	"time"
 
 	"github.com/zitadel/saml/pkg/provider/xml/saml"

diff --git a/pkg/provider/response.go b/pkg/provider/response.go
@@ -4,7 +4,7 @@ import (
 	"encoding/base64"
 	"fmt"
 	"net/http"
-	"text/template"
+	"html/template"
 	"time"
 
 	"github.com/zitadel/saml/pkg/provider/xml"

diff --git a/pkg/provider/template.go b/pkg/provider/template.go
@@ -1,6 +1,6 @@
 package provider
 
-const postTemplate = `<?xml version="1.0" encoding="UTF-8"?>
+const postTemplate = `
 <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
 "http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
 <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en">
@@ -27,7 +27,7 @@ value="{{ .SAMLResponse }}"/>
 </body>
 </html>`
 
-const logoutTemplate = `<?xml version="1.0" encoding="UTF-8"?>
+const logoutTemplate = `
 <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
 "http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
 <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en">