Skip to content

Add more sensor units to the home assistant Long term statistics #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

krusta4711
Copy link
Contributor

@krusta4711 krusta4711 commented Sep 6, 2024

Historical data in home assistant is purged after 10 days unless a sensor has defined the attribute state_class. At present only temperature and percentages are treated by ism7mqtt to be valuable for the home assistant long term statistics.

I think nearly all values are important to have them long term to be able to compare certain situations. So I added a few more units.

THE CHANGE IS NOT TESTED YET as due to my other long running test I do not want to stop at present (#115 ). So this just a draft PR.

@zivillian
Copy link
Owner

zivillian commented Sep 6, 2024

  • It looks sane
  • it compiled successfully

I'd say go ahead and let's merge it.

@zivillian zivillian marked this pull request as ready for review March 10, 2025 10:57
@zivillian zivillian merged commit 53fedb1 into zivillian:master Mar 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants