Repository navigation
fix(ci): custom build takes Node from package.json, as upstream release does - #35
Merged
Merged
Conversation
…se does Upstream now builds the native CLI only with the exact engines.node from package.json (26.12.1). Our pinned VP_NODE_VERSION 26.8.2 overrode it, so the first custom-v2 build after the 2026-10-27 sync failed on both platforms. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since the sync in #34,
apps/server/vite.config.tsbuilds the native CLI only with the exactengines.nodefrompackage.json. Our pinned 26.8.2 overrode it.Evidence
custom-v2(f023fc7) failed on both platforms:Native CLI executables must be built with Node 26.12.1; running 26.8.2.Nocli-*artifacts, sot3-switch-build.shhas nothing to install.After: this branch's diff against
custom-v2removes only thatenv:block; the workflow parses. The real proof is the build run oncustom-v2after merge.Merge Danger
Door: two-way
Blast Radius: small
Only the custom Mac/Linux CLI build job. A wrong Node there fails the build loudly; nothing installs.
🤖 Generated with Claude Code