Skip to content

fix(ci): custom build takes Node from package.json, as upstream release does - #35

Merged
ziyadakl merged 2 commits into
custom-v2from
fix/build-node-from-package
Oct 27, 2026
Merged

ziyadakl merged 2 commits into
custom-v2from
fix/build-node-from-package

Conversation

@ziyadakl

Copy link
Copy Markdown
Owner

Summary

 .github/workflows/custom-mac-build.yml
-env:
-  VP_NODE_VERSION: "26.8.2"     # overrode node-version-file
 Setup Vite+
   node-version-file: package.json   # engines.node = 26.12.1, as release.yml uses

Since the sync in #34, apps/server/vite.config.ts builds the native CLI only with the exact engines.node from package.json. Our pinned 26.8.2 overrode it.

Evidence

  • Before: run 40439178327 on custom-v2 (f023fc7) failed on both platforms: Native CLI executables must be built with Node 26.12.1; running 26.8.2. No cli-* artifacts, so t3-switch-build.sh has nothing to install.
    After: this branch's diff against custom-v2 removes only that env: block; the workflow parses. The real proof is the build run on custom-v2 after merge.

Merge Danger

Door: two-way

Blast Radius: small

Only the custom Mac/Linux CLI build job. A wrong Node there fails the build loudly; nothing installs.

🤖 Generated with Claude Code

…se does

Upstream now builds the native CLI only with the exact engines.node from
package.json (26.12.1). Our pinned VP_NODE_VERSION 26.8.2 overrode it, so
the first custom-v2 build after the 2026-10-27 sync failed on both platforms.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS labels Oct 27, 2026
@ziyadakl
ziyadakl merged commit 9e3fa95 into custom-v2 Oct 27, 2026
26 checks passed
@ziyadakl
ziyadakl deleted the fix/build-node-from-package branch October 27, 2026 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants